Re: build gdbserver with -Werror by default

[Pedro Alves <pedro@codesourcery.com>]

On Friday 27 August 2010 15:50:05, Daniel Jacobowitz wrote:
> 
> On Fri, Aug 27, 2010 at 11:29:08AM +0100, Pedro Alves wrote:
> > and it'd fail elsewhere if it kept going, most probably.  GDB has
> > a bunch of suspicious code like this as well (e.g., in remote.c), so it
> > ended up with -Wno-char-subscripts.  I didn't bring that warning over to
> > gdbserver, as I didn't see any warning when building for linux and
> > mingw32, so I thought it was unnecessary (it is probably gcc version
> > dependent whether that's part of -Wall).  Since this is certainly
> > not a new warning (it's the fact that it causes an error that it's new)
> > I've now added -Wno-char-subscripts to gdbserver as well...
> 
> Having just run into this, not all implementations of the C library
> arrange for isdigit et al to report a char-subscript error.  The GLIBC
> version casts the argument to int; just recently, newlib started
> deliberately issuing the error.

Ah, right, I followed that newlib discussion, but didn't connect
the dots in cygwin-uses-newlib.

-- 
Pedro Alves