From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9521 invoked by alias); 27 Aug 2010 14:54:43 -0000 Received: (qmail 9502 invoked by uid 22791); 27 Aug 2010 14:54:42 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Aug 2010 14:54:30 +0000 Received: (qmail 30957 invoked from network); 27 Aug 2010 14:54:28 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Aug 2010 14:54:28 -0000 From: Pedro Alves To: Daniel Jacobowitz Subject: Re: build gdbserver with -Werror by default Date: Fri, 27 Aug 2010 14:54:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Pierre Muller References: <201008261917.51934.pedro@codesourcery.com> <201008271129.08333.pedro@codesourcery.com> <20100827145003.GA22186@caradoc.them.org> In-Reply-To: <20100827145003.GA22186@caradoc.them.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008271554.27941.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00463.txt.bz2 On Friday 27 August 2010 15:50:05, Daniel Jacobowitz wrote: > > On Fri, Aug 27, 2010 at 11:29:08AM +0100, Pedro Alves wrote: > > and it'd fail elsewhere if it kept going, most probably. GDB has > > a bunch of suspicious code like this as well (e.g., in remote.c), so it > > ended up with -Wno-char-subscripts. I didn't bring that warning over to > > gdbserver, as I didn't see any warning when building for linux and > > mingw32, so I thought it was unnecessary (it is probably gcc version > > dependent whether that's part of -Wall). Since this is certainly > > not a new warning (it's the fact that it causes an error that it's new) > > I've now added -Wno-char-subscripts to gdbserver as well... > > Having just run into this, not all implementations of the C library > arrange for isdigit et al to report a char-subscript error. The GLIBC > version casts the argument to int; just recently, newlib started > deliberately issuing the error. Ah, right, I followed that newlib discussion, but didn't connect the dots in cygwin-uses-newlib. -- Pedro Alves