From: Daniel Jacobowitz <dan@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: build gdbserver with -Werror by default
Date: Fri, 27 Aug 2010 14:50:00 -0000 [thread overview]
Message-ID: <20100827145003.GA22186@caradoc.them.org> (raw)
In-Reply-To: <201008271129.08333.pedro@codesourcery.com>
On Fri, Aug 27, 2010 at 11:29:08AM +0100, Pedro Alves wrote:
> and it'd fail elsewhere if it kept going, most probably. GDB has
> a bunch of suspicious code like this as well (e.g., in remote.c), so it
> ended up with -Wno-char-subscripts. I didn't bring that warning over to
> gdbserver, as I didn't see any warning when building for linux and
> mingw32, so I thought it was unnecessary (it is probably gcc version
> dependent whether that's part of -Wall). Since this is certainly
> not a new warning (it's the fact that it causes an error that it's new)
> I've now added -Wno-char-subscripts to gdbserver as well...
Having just run into this, not all implementations of the C library
arrange for isdigit et al to report a char-subscript error. The GLIBC
version casts the argument to int; just recently, newlib started
deliberately issuing the error.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-08-27 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 18:18 Pedro Alves
2010-08-27 8:57 ` Pierre Muller
2010-08-27 10:29 ` Pedro Alves
2010-08-27 14:50 ` Daniel Jacobowitz [this message]
2010-08-27 14:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827145003.GA22186@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox