From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7346 invoked by alias); 27 Aug 2010 14:50:17 -0000 Received: (qmail 7334 invoked by uid 22791); 27 Aug 2010 14:50:16 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Aug 2010 14:50:10 +0000 Received: (qmail 27914 invoked from network); 27 Aug 2010 14:50:08 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Aug 2010 14:50:08 -0000 Date: Fri, 27 Aug 2010 14:50:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org, Pierre Muller Subject: Re: build gdbserver with -Werror by default Message-ID: <20100827145003.GA22186@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org, Pierre Muller References: <201008261917.51934.pedro@codesourcery.com> <001e01cb45c5$a6b53b40$f41fb1c0$@muller@ics-cnrs.unistra.fr> <201008271129.08333.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008271129.08333.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00462.txt.bz2 On Fri, Aug 27, 2010 at 11:29:08AM +0100, Pedro Alves wrote: > and it'd fail elsewhere if it kept going, most probably. GDB has > a bunch of suspicious code like this as well (e.g., in remote.c), so it > ended up with -Wno-char-subscripts. I didn't bring that warning over to > gdbserver, as I didn't see any warning when building for linux and > mingw32, so I thought it was unnecessary (it is probably gcc version > dependent whether that's part of -Wall). Since this is certainly > not a new warning (it's the fact that it causes an error that it's new) > I've now added -Wno-char-subscripts to gdbserver as well... Having just run into this, not all implementations of the C library arrange for isdigit et al to report a char-subscript error. The GLIBC version casts the argument to int; just recently, newlib started deliberately issuing the error. -- Daniel Jacobowitz CodeSourcery