From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb
Date: Wed, 18 Aug 2010 03:22:00 -0000 [thread overview]
Message-ID: <20100818032219.GC22704@qiyaows> (raw)
In-Reply-To: <201008161818.o7GII777014877@glazunov.sibelius.xs4all.nl>
On Mon, Aug 16, 2010 at 08:18:07PM +0200, Mark Kettenis wrote:
> > Date: Mon, 16 Aug 2010 23:39:21 +0800
> > From: "Yao Qi" <yao@codesourcery.com>
> >
> > >
> > > Looks fine to me. Mark, what do you think?
> >
> > Mark,
> > Is this patch OK to you?
>
> Sorry, I though I replied to Daniel's message.
>
> Anyway, I'm afraid I don't understand the problem you're trying to
> fix, so it's hard to say for me that the diff is ok. However, I'd say
> that 32-bit alignment should be enough; I don't know any architectures
> that have instructions longer than 32-bits and care about alignment.
Yeah, I agree. Patch is committed.
http://sourceware.org/ml/gdb-cvs/2010-08/msg00098.html
http://sourceware.org/ml/gdb-cvs/2010-08/msg00099.html
--
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739
prev parent reply other threads:[~2010-08-18 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 8:18 Yao Qi
2010-08-12 9:38 ` Mark Kettenis
2010-08-12 11:49 ` Yao Qi
2010-08-12 12:35 ` Daniel Jacobowitz
2010-08-12 12:45 ` Andreas Schwab
2010-08-12 13:22 ` Yao Qi
2010-08-13 13:28 ` Daniel Jacobowitz
2010-08-16 15:39 ` Yao Qi
2010-08-16 18:19 ` Mark Kettenis
2010-08-18 3:22 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818032219.GC22704@qiyaows \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox