From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17502 invoked by alias); 18 Aug 2010 03:22:34 -0000 Received: (qmail 17491 invoked by uid 22791); 18 Aug 2010 03:22:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Aug 2010 03:22:28 +0000 Received: (qmail 6893 invoked from network); 18 Aug 2010 03:22:26 -0000 Received: from unknown (HELO qiyaows) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Aug 2010 03:22:26 -0000 Date: Wed, 18 Aug 2010 03:22:00 -0000 From: Yao Qi To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb Message-ID: <20100818032219.GC22704@qiyaows> References: <20100812081814.GA24769@qiyaows> <201008120935.o7C9Zpid015638@glazunov.sibelius.xs4all.nl> <20100812114907.GB24769@qiyaows> <20100812123437.GA31629@caradoc.them.org> <20100812132153.GC24769@qiyaows> <20100813132811.GA20656@caradoc.them.org> <20100816153920.GA20732@qiyaows> <201008161818.o7GII777014877@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008161818.o7GII777014877@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00286.txt.bz2 On Mon, Aug 16, 2010 at 08:18:07PM +0200, Mark Kettenis wrote: > > Date: Mon, 16 Aug 2010 23:39:21 +0800 > > From: "Yao Qi" > > > > > > > > Looks fine to me. Mark, what do you think? > > > > Mark, > > Is this patch OK to you? > > Sorry, I though I replied to Daniel's message. > > Anyway, I'm afraid I don't understand the problem you're trying to > fix, so it's hard to say for me that the diff is ok. However, I'd say > that 32-bit alignment should be enough; I don't know any architectures > that have instructions longer than 32-bits and care about alignment. Yeah, I agree. Patch is committed. http://sourceware.org/ml/gdb-cvs/2010-08/msg00098.html http://sourceware.org/ml/gdb-cvs/2010-08/msg00099.html -- Yao Qi CodeSourcery yao@codesourcery.com (650) 331-3385 x739