From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <kettenis@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb
Date: Mon, 16 Aug 2010 15:39:00 -0000 [thread overview]
Message-ID: <20100816153920.GA20732@qiyaows> (raw)
In-Reply-To: <20100813132811.GA20656@caradoc.them.org>
> > >
> > > Can you use func_loopfb instead of func_loopfb_start in the .S file?
> > > Or, can you define func_loopfb_start as asm ("func_loopfb_start =
> > > func_loopfb")?
> > >
> > > A third option is to address Mark's concern by using ".p2align 4"; I
> > > believe that is 16-byte alignment on all platforms gas supports, and
> > > this test probably requires gas in practice already.
> >
> > Yeah, update my patch by replacing '.align 2' with '.p2align 4'.
> > Is that OK?
>
> Looks fine to me. Mark, what do you think?
Mark,
Is this patch OK to you?
--
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739
next prev parent reply other threads:[~2010-08-16 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 8:18 Yao Qi
2010-08-12 9:38 ` Mark Kettenis
2010-08-12 11:49 ` Yao Qi
2010-08-12 12:35 ` Daniel Jacobowitz
2010-08-12 12:45 ` Andreas Schwab
2010-08-12 13:22 ` Yao Qi
2010-08-13 13:28 ` Daniel Jacobowitz
2010-08-16 15:39 ` Yao Qi [this message]
2010-08-16 18:19 ` Mark Kettenis
2010-08-18 3:22 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816153920.GA20732@qiyaows \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox