From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9072 invoked by alias); 16 Aug 2010 15:39:44 -0000 Received: (qmail 9060 invoked by uid 22791); 16 Aug 2010 15:39:43 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Aug 2010 15:39:37 +0000 Received: (qmail 15360 invoked from network); 16 Aug 2010 15:39:35 -0000 Received: from unknown (HELO qiyaows) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Aug 2010 15:39:35 -0000 Date: Mon, 16 Aug 2010 15:39:00 -0000 From: Yao Qi To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH,Testsuite] Add .align 2 for labels on Thumb Message-ID: <20100816153920.GA20732@qiyaows> References: <20100812081814.GA24769@qiyaows> <201008120935.o7C9Zpid015638@glazunov.sibelius.xs4all.nl> <20100812114907.GB24769@qiyaows> <20100812123437.GA31629@caradoc.them.org> <20100812132153.GC24769@qiyaows> <20100813132811.GA20656@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100813132811.GA20656@caradoc.them.org> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00223.txt.bz2 > > > > > > Can you use func_loopfb instead of func_loopfb_start in the .S file? > > > Or, can you define func_loopfb_start as asm ("func_loopfb_start = > > > func_loopfb")? > > > > > > A third option is to address Mark's concern by using ".p2align 4"; I > > > believe that is 16-byte alignment on all platforms gas supports, and > > > this test probably requires gas in practice already. > > > > Yeah, update my patch by replacing '.align 2' with '.p2align 4'. > > Is that OK? > > Looks fine to me. Mark, what do you think? Mark, Is this patch OK to you? -- Yao Qi CodeSourcery yao@codesourcery.com (650) 331-3385 x739