Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1810 bytes --]

On Saturday, July 17, 2010 05:53:04 Ozkan Sezer wrote:
> On Sat, Jul 17, 2010 at 12:42 PM, Ozkan Sezer <sezeroz@gmail.com> wrote:
> > On Sat, Jul 17, 2010 at 12:37 PM, Mike Frysinger <vapier@gentoo.org> 
wrote:
> >> On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote:
> >>> For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32)
> >>> gcc complains:
> >>> 
> >>> ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query':
> >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown
> >>> conversion type character 'l' in format
> >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many
> >>> arguments for format
> >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown
> >>> conversion type character 'l' in format
> >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many
> >>> arguments for format
> >>> 
> >>> This is due to the fact that MS printf doesn't support %lld, it uses
> >>> its own %I64d which gcc already knows about. The attached patch
> >>> changes that. OK for apply?
> >> 
> >> ugh, no.  why not use a sane define like PRIx64 from inttypes.h ?
> > 
> > I would happily do that, however that would require inttypes
> > module merge from gnulib to gdb/gnulib, am I wrong?
> 
> To be clear, I modified a patch I submitted before to not use
> the inttypes PRI macros:
> http://sourceware.org/ml/gdb-patches/2010-07/msg00244.html
> 
> By analogy, I might use paddress() instead, but for that case
> please see the issue I reported at
> http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html
> 
> Comments?

random #ifdefs like this are highly discouraged.  if you could find another 
way, that'd be great.  but i dont think importing a few small modules from 
gnulib is a big deal ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]