From: Ozkan Sezer <sezeroz@gmail.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH] [Windows] fix format string for 64 bit var in gdbserver
Date: Fri, 16 Jul 2010 20:10:00 -0000 [thread overview]
Message-ID: <AANLkTilqLsYAUtXVYK-DL-uDFyKVbsxEz2CmJyJoese7@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
Hi!
For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32)
gcc complains:
../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query':
../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown
conversion type character 'l' in format
../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many
arguments for format
../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown
conversion type character 'l' in format
../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many
arguments for format
This is due to the fact that MS printf doesn't support %lld, it uses
its own %I64d which gcc already knows about. The attached patch
changes that. OK for apply?
gdb/gdbserver/
* server.c (handle_query): For windows, use %I64d instead of %lld in
the sprintf format string.
--
Ozkan
[-- Attachment #2: g2.diff --]
[-- Type: application/octet-stream, Size: 957 bytes --]
gdb/gdbserver/
* server.c (handle_query): For windows, use %I64d instead of %lld in
the sprintf format string.
Index: gdb/gdbserver/server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.125
diff -u -p -r1.125 server.c
--- gdb/gdbserver/server.c 7 Jul 2010 16:14:04 -0000 1.125
+++ gdb/gdbserver/server.c 16 Jul 2010 20:05:51 -0000
@@ -1539,7 +1539,11 @@ handle_query (char *own_buf, int packet_
if (err == 0)
{
+#ifdef _WIN32
+ sprintf (own_buf, "%I64d", address);
+#else
sprintf (own_buf, "%llx", address);
+#endif
return;
}
else if (err > 0)
@@ -1563,7 +1567,11 @@ handle_query (char *own_buf, int packet_
n = (*the_target->get_tib_address) (ptid, &tlb);
if (n == 1)
{
+#ifdef _WIN32
+ sprintf (own_buf, "%I64d", tlb);
+#else
sprintf (own_buf, "%llx", tlb);
+#endif
return;
}
else if (n == 0)
next reply other threads:[~2010-07-16 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 20:10 Ozkan Sezer [this message]
2010-07-17 9:40 ` Mike Frysinger
2010-07-17 9:42 ` Ozkan Sezer
2010-07-17 9:53 ` Ozkan Sezer
2010-07-17 18:50 ` Mike Frysinger
2010-07-17 18:59 ` Ozkan Sezer
2010-07-17 19:19 ` Mike Frysinger
2010-07-17 19:23 ` Ozkan Sezer
2010-07-17 21:01 ` Andreas Schwab
2010-07-17 21:05 ` Ozkan Sezer
2010-07-20 18:20 ` Ozkan Sezer
2010-07-17 12:29 ` Mark Kettenis
2010-07-17 18:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilqLsYAUtXVYK-DL-uDFyKVbsxEz2CmJyJoese7@mail.gmail.com \
--to=sezeroz@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox