From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31956 invoked by alias); 17 Jul 2010 18:50:39 -0000 Received: (qmail 31946 invoked by uid 22791); 17 Jul 2010 18:50:39 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jul 2010 18:50:35 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id F24161B400F; Sat, 17 Jul 2010 18:50:33 +0000 (UTC) From: Mike Frysinger To: Ozkan Sezer Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver Date: Sat, 17 Jul 2010 18:50:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.4; x86_64; ; ) Cc: gdb-patches@sourceware.org, Tom Tromey References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1316352.PlOCMIrIdK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201007171447.38746.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00262.txt.bz2 --nextPart1316352.PlOCMIrIdK Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1793 On Saturday, July 17, 2010 05:53:04 Ozkan Sezer wrote: > On Sat, Jul 17, 2010 at 12:42 PM, Ozkan Sezer wrote: > > On Sat, Jul 17, 2010 at 12:37 PM, Mike Frysinger =20 wrote: > >> On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote: > >>> For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32) > >>> gcc complains: > >>>=20 > >>> ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query': > >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown > >>> conversion type character 'l' in format > >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many > >>> arguments for format > >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown > >>> conversion type character 'l' in format > >>> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many > >>> arguments for format > >>>=20 > >>> This is due to the fact that MS printf doesn't support %lld, it uses > >>> its own %I64d which gcc already knows about. The attached patch > >>> changes that. OK for apply? > >>=20 > >> ugh, no. why not use a sane define like PRIx64 from inttypes.h ? > >=20 > > I would happily do that, however that would require inttypes > > module merge from gnulib to gdb/gnulib, am I wrong? >=20 > To be clear, I modified a patch I submitted before to not use > the inttypes PRI macros: > http://sourceware.org/ml/gdb-patches/2010-07/msg00244.html >=20 > By analogy, I might use paddress() instead, but for that case > please see the issue I reported at > http://sourceware.org/ml/gdb-patches/2010-07/msg00254.html >=20 > Comments? random #ifdefs like this are highly discouraged. if you could find another= =20 way, that'd be great. but i dont think importing a few small modules from= =20 gnulib is a big deal ? -mike --nextPart1316352.PlOCMIrIdK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMQfrKAAoJEEFjO5/oN/WBjyoP+wYaner0Gzra1PQ65DFTfDDt MfDp8dOtm4Ej+5N7c+GUXnuLP1glmhvgXtdKa8iOab7pQUOcfPKmy3izNS/k7LO2 cIZS6jDjXOuIQpj/FSaioimqfjov7IIAQPIvACWOTfCas/8gpGHT0YpvgTsQijQs FNhe9kiLQjaMG04ZbjmvJCK5ViyuRoXIV9R/67FSfQgrO1BULe8Bj5s40o9vt1GV mH1Vu35wiAtY/BGvUrBezo9T/ImLSlR0T0CWZkCdETz52ETNC2rGO5fzJdHTtwC+ 8gGt6R55dgcREpTqJoKTFwd+KEXoaKvxpUMn3j4SCwHiyXdeSjCHlLT1chLMX9NN BR4zVVxCVYz7IGIm2K1TceYzIQKC5P+y9RSRS0R54fjsClQPPth1SVLGRp49+NnF LhSXTVBSNFErZakzxCBBbwc8M/GMQQV+tMEAeAH3PLXL/mdavuW7UsMF+OEnJD3F Nn9znxeYYEezj3d8Py5lppW3aIqi0OMz5PnW8/Hit7sRO7trMMSB+t+o9LkdC3OT 1MUPUeET9frVs8IGK06Q5U0+bzd5q5eFXFyBVGdQcmVmwmQOTOnkGQ1ULGcbycUf FD6bzWhIEBVeTkn5RE+Sil2iRVjNby8zHembVtaVsEafMyvb72oshmG9AQys6n8K JWKdhjhQnbS6QvSI52tI =WPWZ -----END PGP SIGNATURE----- --nextPart1316352.PlOCMIrIdK--