From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>,
Stan Shebs <stan@codesourcery.com>
Subject: Re: collecting optimized out variables regression (Re: RFA: rewrite dwarf->ax translator (Was: RFC: implement DW_OP_bit_piece))
Date: Thu, 01 Jul 2010 15:34:00 -0000 [thread overview]
Message-ID: <20100701153350.GA7388@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <201007011343.00392.pedro@codesourcery.com>
On Thu, 01 Jul 2010 14:42:59 +0200, Pedro Alves wrote:
> + if (dlbaton->data == NULL || dlbaton->size == 0)
If SIZE != 0 then DATA must be != NULL otherwise GDB would crash elsewhere.
dwarf2_evaluate_loc_desc is already using this easier to read conditional:
if (size == 0)
which means:
if (dlbaton->size == 0)
Thanks,
Jan
next prev parent reply other threads:[~2010-07-01 15:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 23:43 RFC: implement DW_OP_bit_piece Tom Tromey
2010-05-19 14:16 ` Stan Shebs
2010-05-19 23:35 ` Tom Tromey
2010-05-20 3:29 ` Stan Shebs
2010-05-20 5:10 ` Tom Tromey
2010-05-20 7:12 ` Tom Tromey
2010-05-26 22:41 ` Tom Tromey
2010-06-03 20:12 ` RFA: rewrite dwarf->ax translator (Was: RFC: implement DW_OP_bit_piece) Tom Tromey
2010-06-08 20:45 ` RFA: rewrite dwarf->ax translator Tom Tromey
2010-06-11 15:20 ` Tom Tromey
2010-06-08 20:52 ` RFA: rewrite dwarf->ax translator (Was: RFC: implement DW_OP_bit_piece) Pedro Alves
2010-06-08 21:21 ` RFA: rewrite dwarf->ax translator Tom Tromey
2010-06-08 22:48 ` Tom Tromey
2010-06-09 14:04 ` Pedro Alves
2010-07-01 12:43 ` collecting optimized out variables regression (Re: RFA: rewrite dwarf->ax translator (Was: RFC: implement DW_OP_bit_piece)) Pedro Alves
2010-07-01 15:25 ` collecting optimized out variables regression (Re: RFA: rewrite dwarf->ax translator Tom Tromey
2010-07-01 15:57 ` Pedro Alves
2010-07-01 15:34 ` Jan Kratochvil [this message]
2010-05-20 19:53 ` RFC: implement DW_OP_bit_piece Tom Tromey
2010-05-20 20:30 ` Jan Kratochvil
2010-05-21 20:16 ` Tom Tromey
2010-05-21 21:16 ` Stan Shebs
2010-05-21 21:18 ` Tom Tromey
2010-05-25 19:22 ` RFC: DWARF expression disassembly (Was: RFC: implement DW_OP_bit_piece) Tom Tromey
2010-05-25 19:27 ` Jan Kratochvil
2010-05-25 20:25 ` RFC: DWARF expression disassembly Tom Tromey
2010-05-25 20:52 ` Jan Kratochvil
2010-05-25 22:03 ` Tom Tromey
2010-05-26 17:21 ` Eli Zaretskii
2010-06-01 18:36 ` Tom Tromey
2010-06-01 18:40 ` Eli Zaretskii
2010-06-02 19:32 ` Tom Tromey
2010-05-20 21:07 ` RFC: implement DW_OP_bit_piece Jan Kratochvil
2010-05-21 17:57 ` Tom Tromey
2010-05-25 18:19 ` performance talk [Re: RFC: implement DW_OP_bit_piece] Jan Kratochvil
2010-05-25 22:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701153350.GA7388@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=stan@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox