From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74119-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4566 invoked by alias); 1 Jul 2010 15:34:16 -0000
Received: (qmail 4551 invoked by uid 22791); 1 Jul 2010 15:34:15 -0000
X-SWARE-Spam-Status: No, hits=-5.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_DL,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 15:34:05 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o61FXs7p007788	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 1 Jul 2010 11:33:54 -0400
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o61FXqsB030750	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Thu, 1 Jul 2010 11:33:53 -0400
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o61FXpmX007647;	Thu, 1 Jul 2010 17:33:51 +0200
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o61FXooj007646;	Thu, 1 Jul 2010 17:33:50 +0200
Date: Thu, 01 Jul 2010 15:34:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>,        Stan Shebs <stan@codesourcery.com>
Subject: Re: collecting optimized out variables regression (Re: RFA: rewrite dwarf->ax translator (Was: RFC: implement DW_OP_bit_piece))
Message-ID: <20100701153350.GA7388@host0.dyn.jankratochvil.net>
References: <m3ljbgdc4a.fsf@fleche.redhat.com> <m3r5kyl3zt.fsf@fleche.redhat.com> <m3ocfrzxia.fsf_-_@fleche.redhat.com> <201007011343.00392.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201007011343.00392.pedro@codesourcery.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00010.txt.bz2

On Thu, 01 Jul 2010 14:42:59 +0200, Pedro Alves wrote:
> +  if (dlbaton->data == NULL || dlbaton->size == 0)

If SIZE != 0 then DATA must be != NULL otherwise GDB would crash elsewhere.

dwarf2_evaluate_loc_desc is already using this easier to read conditional:
  if (size == 0)
which means:
  if (dlbaton->size == 0)


Thanks,
Jan