From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: partially fix empty DW_OP_piece
Date: Thu, 03 Jun 2010 17:46:00 -0000 [thread overview]
Message-ID: <20100603174558.GA22100@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3ocft2o6q.fsf@fleche.redhat.com>
On Wed, 02 Jun 2010 22:07:41 +0200, Tom Tromey wrote:
> I think the current gdb model is that a value is a snapshot of some
> inferior state at a particular moment.
>
> So, for VLA I would say that the bounds ought to be fixed at the time
> the snapshot is taken. I suppose this would mean introducing some copy
> of the type.
That is interesting idea (and currently in the VLA patch it happens that way).
Still it is probably really needed only for the GDB values history.
> Right now what I've done is change val_print to:
>
> int
> val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset,
> CORE_ADDR address, struct ui_file *stream, int recurse,
> const struct value *val,
> const struct value_print_options *options,
> const struct language_defn *language)
>
> That is, I added the new 'val' argument. This is only used for bit
> validity testing.
As we talked with Tom he has already the patch coded+working. I thought only
a plan for his coding is being discussed now. Therefore leaving the VLA
design decision for a later point unrelated to his current patch.
Thanks,
Jan
next prev parent reply other threads:[~2010-06-03 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 6:39 Tom Tromey
2010-05-14 22:51 ` Jan Kratochvil
2010-05-21 19:48 ` Tom Tromey
2010-06-01 17:34 ` Tom Tromey
2010-06-02 18:54 ` Jan Kratochvil
2010-06-02 20:07 ` Tom Tromey
2010-06-03 17:46 ` Jan Kratochvil [this message]
2010-06-04 19:05 ` Tom Tromey
2010-06-04 19:10 ` Jan Kratochvil
2010-06-04 21:39 ` Tom Tromey
2010-06-04 21:47 ` Jan Kratochvil
2010-05-20 23:04 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603174558.GA22100@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox