From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10178 invoked by alias); 3 Jun 2010 17:46:11 -0000 Received: (qmail 10161 invoked by uid 22791); 3 Jun 2010 17:46:09 -0000 X-SWARE-Spam-Status: No, hits=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Jun 2010 17:46:03 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o53Hk1K4003615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 3 Jun 2010 13:46:01 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o53HjxM8000588 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Jun 2010 13:46:01 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o53HjwJv022681; Thu, 3 Jun 2010 19:45:59 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o53HjwBp022680; Thu, 3 Jun 2010 19:45:58 +0200 Date: Thu, 03 Jun 2010 17:46:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: partially fix empty DW_OP_piece Message-ID: <20100603174558.GA22100@host0.dyn.jankratochvil.net> References: <20100514223521.GA3975@host0.dyn.jankratochvil.net> <20100602185354.GA11125@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00102.txt.bz2 On Wed, 02 Jun 2010 22:07:41 +0200, Tom Tromey wrote: > I think the current gdb model is that a value is a snapshot of some > inferior state at a particular moment. > > So, for VLA I would say that the bounds ought to be fixed at the time > the snapshot is taken. I suppose this would mean introducing some copy > of the type. That is interesting idea (and currently in the VLA patch it happens that way). Still it is probably really needed only for the GDB values history. > Right now what I've done is change val_print to: > > int > val_print (struct type *type, const gdb_byte *valaddr, int embedded_offset, > CORE_ADDR address, struct ui_file *stream, int recurse, > const struct value *val, > const struct value_print_options *options, > const struct language_defn *language) > > That is, I added the new 'val' argument. This is only used for bit > validity testing. As we talked with Tom he has already the patch coded+working. I thought only a plan for his coding is being discussed now. Therefore leaving the VLA design decision for a later point unrelated to his current patch. Thanks, Jan