Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: partially fix empty DW_OP_piece
Date: Thu, 20 May 2010 23:04:00 -0000	[thread overview]
Message-ID: <20100520230326.GJ3019@adacore.com> (raw)
In-Reply-To: <m3vdars0hy.fsf@fleche.redhat.com>

> This patch "fixes" the problem in a simple way.  Missing pieces are
> filled with zeros, and read_pieced_value emits a warning, so that users
> know not to fully trust the result.
> 
> This is not an excellent fix.  I think it is an improvement, but I can
> understand if people would rather not see it go in.

I also think that this is an improvement, and that it should go in.

> I thought of two ways to implement the val_print part.  One way would be
> to make a temporary 'struct type' instance that encodes the validity in
> the type somehow.  The other way is to simply remove val_print entirely
> and make all of printing work using values.  I think this is the route I
> would prefer.

FWIW:
I think that would be my preference indeed. Generally speaking, it looks
like our struct type is headed for some major upgrades, once we start
thinking about making some elements of a type dynamic (Eg: range type
bounds, array bounds). But using a temporary type to track the validity
of a field for a given entity does not seem to be the right idiom...

-- 
Joel


      parent reply	other threads:[~2010-05-20 23:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14  6:39 Tom Tromey
2010-05-14 22:51 ` Jan Kratochvil
2010-05-21 19:48   ` Tom Tromey
2010-06-01 17:34   ` Tom Tromey
2010-06-02 18:54     ` Jan Kratochvil
2010-06-02 20:07       ` Tom Tromey
2010-06-03 17:46         ` Jan Kratochvil
2010-06-04 19:05           ` Tom Tromey
2010-06-04 19:10             ` Jan Kratochvil
2010-06-04 21:39               ` Tom Tromey
2010-06-04 21:47                 ` Jan Kratochvil
2010-05-20 23:04 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100520230326.GJ3019@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox