Re: [patch] new testcase: Internal error on unqualified name re-set (PR 11657)

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 02 Jun 2010 17:03:50 +0200, Pedro Alves wrote:
> On Wednesday 02 June 2010 15:32:33, Jan Kratochvil wrote:
> 
> > +# Create and source the file that provides information about the compiler
> > +# used to compile the test case.
> > +if [get_compiler_info ${binfile} "c++"] {
> > +    return -1
> > +}
> 
> Is this bit actually needed in this test?

Yes.

lib/gdb.exp:
	# Build a shared library from SOURCES.  You must use get_compiler_info
	# first.
	proc gdb_compile_shlib {sources dest options} {


> > +clean_restart $executable
> > +gdb_load_shlibs ${sofile}
> > +
> > +gdb_test_no_output "set breakpoint pending yes"
> > +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C"
> > +gdb_test_no_output {set variable $brk = $bpnum}
> > +
> > +gdb_breakpoint "main"
> > +gdb_run_cmd
> > +gdb_test "" "" "start"
> 
> Doesn't runto_main work in this case?

No.  Added:
	# runto or runto_main would call delete_breakpoints.


> So will the test hit an internal error, causing a new FAIL?
> How about setting up a kfail with the PR number?

Forgot, KFAILed now:
	Running ./gdb.cp/re-set-overloaded.exp ...
	PASS: gdb.cp/re-set-overloaded.exp: set breakpoint pending yes
	PASS: gdb.cp/re-set-overloaded.exp: break C::C
	PASS: gdb.cp/re-set-overloaded.exp: set variable $brk = $bpnum
	KFAIL: gdb.cp/re-set-overloaded.exp: start (GDB internal error) (PRMS: breakpoints/11657)
	KFAIL: gdb.cp/re-set-overloaded.exp: breakpoint resolved (PRMS: breakpoints/11657)

OK to check-in?


Thanks,
Jan


gdb/testsuite/
2010-06-02  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.cp/re-set-overloaded.exp, gdb.cp/re-set-overloaded.cc: New.

--- /dev/null
+++ b/gdb/testsuite/gdb.cp/re-set-overloaded.cc
@@ -0,0 +1,26 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2010 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+class C
+  {
+  public:
+    C() {}
+    C(int x) {}
+  };
+
+C a;
+C b(1);
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/re-set-overloaded.exp
@@ -0,0 +1,61 @@
+# Copyright 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+if { [skip_cplus_tests] } { continue }
+if { [skip_shlib_tests] } { continue }
+
+set testfile re-set-overloaded
+set srcfile bool.cc
+set executable $testfile
+set binfile $objdir/$subdir/$executable
+
+set libsrcfile ${testfile}.cc
+set sofile $objdir/$subdir/${testfile}.so
+
+# Create and source the file that provides information about the compiler
+# used to compile the test case.
+if [get_compiler_info ${binfile} "c++"] {
+    return -1
+}
+
+if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++}] != ""
+     || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list debug "c++" shlib=${sofile}]] != ""} {
+    untested ${testfile}.exp
+    return -1
+}
+
+clean_restart $executable
+gdb_load_shlibs ${sofile}
+
+gdb_test_no_output "set breakpoint pending yes"
+gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C"
+gdb_test_no_output {set variable $brk = $bpnum}
+
+# runto or runto_main would call delete_breakpoints.
+gdb_breakpoint "main"
+gdb_run_cmd
+setup_kfail breakpoints/11657 *-*-* 
+gdb_test "" "" "start"
+
+set test "breakpoint resolved"
+gdb_test_multiple {info breakpoints $brk} $test {
+    -re "<PENDING>" {
+	kfail breakpoints/11657 $test
+    }
+    -re "\r\n$gdb_prompt $" {
+	# FIXME: Check more specific resolution state.
+	pass $test
+    }
+}