From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21520 invoked by alias); 2 Jun 2010 16:12:48 -0000 Received: (qmail 21463 invoked by uid 22791); 2 Jun 2010 16:12:37 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Jun 2010 16:12:32 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o52GCNfG024381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 2 Jun 2010 12:12:23 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o52GCKL2025784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Jun 2010 12:12:22 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o52GCK0g032375; Wed, 2 Jun 2010 18:12:20 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o52GCIYr032351; Wed, 2 Jun 2010 18:12:18 +0200 Date: Wed, 02 Jun 2010 16:12:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [patch] new testcase: Internal error on unqualified name re-set (PR 11657) Message-ID: <20100602161218.GA31980@host0.dyn.jankratochvil.net> References: <20100602143233.GA22447@host0.dyn.jankratochvil.net> <201006021603.50479.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201006021603.50479.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00042.txt.bz2 On Wed, 02 Jun 2010 17:03:50 +0200, Pedro Alves wrote: > On Wednesday 02 June 2010 15:32:33, Jan Kratochvil wrote: > > > +# Create and source the file that provides information about the compiler > > +# used to compile the test case. > > +if [get_compiler_info ${binfile} "c++"] { > > + return -1 > > +} > > Is this bit actually needed in this test? Yes. lib/gdb.exp: # Build a shared library from SOURCES. You must use get_compiler_info # first. proc gdb_compile_shlib {sources dest options} { > > +clean_restart $executable > > +gdb_load_shlibs ${sofile} > > + > > +gdb_test_no_output "set breakpoint pending yes" > > +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C" > > +gdb_test_no_output {set variable $brk = $bpnum} > > + > > +gdb_breakpoint "main" > > +gdb_run_cmd > > +gdb_test "" "" "start" > > Doesn't runto_main work in this case? No. Added: # runto or runto_main would call delete_breakpoints. > So will the test hit an internal error, causing a new FAIL? > How about setting up a kfail with the PR number? Forgot, KFAILed now: Running ./gdb.cp/re-set-overloaded.exp ... PASS: gdb.cp/re-set-overloaded.exp: set breakpoint pending yes PASS: gdb.cp/re-set-overloaded.exp: break C::C PASS: gdb.cp/re-set-overloaded.exp: set variable $brk = $bpnum KFAIL: gdb.cp/re-set-overloaded.exp: start (GDB internal error) (PRMS: breakpoints/11657) KFAIL: gdb.cp/re-set-overloaded.exp: breakpoint resolved (PRMS: breakpoints/11657) OK to check-in? Thanks, Jan gdb/testsuite/ 2010-06-02 Jan Kratochvil * gdb.cp/re-set-overloaded.exp, gdb.cp/re-set-overloaded.cc: New. --- /dev/null +++ b/gdb/testsuite/gdb.cp/re-set-overloaded.cc @@ -0,0 +1,26 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2010 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +class C + { + public: + C() {} + C(int x) {} + }; + +C a; +C b(1); --- /dev/null +++ b/gdb/testsuite/gdb.cp/re-set-overloaded.exp @@ -0,0 +1,61 @@ +# Copyright 2010 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +if { [skip_cplus_tests] } { continue } +if { [skip_shlib_tests] } { continue } + +set testfile re-set-overloaded +set srcfile bool.cc +set executable $testfile +set binfile $objdir/$subdir/$executable + +set libsrcfile ${testfile}.cc +set sofile $objdir/$subdir/${testfile}.so + +# Create and source the file that provides information about the compiler +# used to compile the test case. +if [get_compiler_info ${binfile} "c++"] { + return -1 +} + +if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++}] != "" + || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list debug "c++" shlib=${sofile}]] != ""} { + untested ${testfile}.exp + return -1 +} + +clean_restart $executable +gdb_load_shlibs ${sofile} + +gdb_test_no_output "set breakpoint pending yes" +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C" +gdb_test_no_output {set variable $brk = $bpnum} + +# runto or runto_main would call delete_breakpoints. +gdb_breakpoint "main" +gdb_run_cmd +setup_kfail breakpoints/11657 *-*-* +gdb_test "" "" "start" + +set test "breakpoint resolved" +gdb_test_multiple {info breakpoints $brk} $test { + -re "" { + kfail breakpoints/11657 $test + } + -re "\r\n$gdb_prompt $" { + # FIXME: Check more specific resolution state. + pass $test + } +}