From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] new testcase: Internal error on unqualified name re-set (PR 11657)
Date: Wed, 02 Jun 2010 15:04:00 -0000 [thread overview]
Message-ID: <201006021603.50479.pedro@codesourcery.com> (raw)
In-Reply-To: <20100602143233.GA22447@host0.dyn.jankratochvil.net>
On Wednesday 02 June 2010 15:32:33, Jan Kratochvil wrote:
> +# Create and source the file that provides information about the compiler
> +# used to compile the test case.
> +if [get_compiler_info ${binfile} "c++"] {
> + return -1
> +}
Is this bit actually needed in this test?
> +
> +if { [gdb_compile_shlib $srcdir/$subdir/$libsrcfile $sofile {debug c++}] != ""
> + || [gdb_compile $srcdir/$subdir/$srcfile $binfile executable [list debug "c++" shlib=${sofile}]] != ""} {
> + untested ${testfile}.exp
> + return -1
> +}
> +
> +clean_restart $executable
> +gdb_load_shlibs ${sofile}
> +
> +gdb_test_no_output "set breakpoint pending yes"
> +gdb_test "break C::C" {Breakpoint [0-9]+ \(C::C\) pending\.} "break C::C"
> +gdb_test_no_output {set variable $brk = $bpnum}
> +
> +gdb_breakpoint "main"
> +gdb_run_cmd
> +gdb_test "" "" "start"
Doesn't runto_main work in this case?
> +
> +set test "breakpoint resolved"
> +gdb_test_multiple {info breakpoints $brk} $test {
> + -re "<PENDING>" {
> + fail $test
> + }
> + -re "\r\n$gdb_prompt $" {
> + # FIXME: Check more specific resolution state.
> + pass $test
> + }
> +}
>
So will the test hit an internal error, causing a new FAIL?
How about setting up a kfail with the PR number?
--
Pedro Alves
next prev parent reply other threads:[~2010-06-02 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 14:32 Jan Kratochvil
2010-06-02 15:04 ` Pedro Alves [this message]
2010-06-02 16:12 ` Jan Kratochvil
2010-06-02 16:24 ` Joel Brobecker
2010-06-02 16:26 ` Jan Kratochvil
2010-06-02 17:38 ` Jan Kratochvil
2010-06-02 16:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006021603.50479.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox