From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] windows-nat.c: Copy console information for new console
Date: Wed, 26 May 2010 17:20:00 -0000 [thread overview]
Message-ID: <20100526170712.GA32594@ednor.casa.cgf.cx> (raw)
In-Reply-To: <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr>
On Wed, May 26, 2010 at 09:49:05AM +0200, Pierre Muller wrote:
>> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Christopher Faylor
>> I don't mind the concept but this function is becoming pretty big so I
>> would appreciate it if you would move all of the logic into a function.
>> Maybe call it "set_console_info()" and pass it &flags, &si.
>>
>> cgf
>
>
> You are right, this is cleaner, nevertheless flags isn't
>used much,
I actually thought fairly carefully about flags. If you have a function
which controls console info, then the function should set the flags
appropriately to deal with the console info.
cgf
next prev parent reply other threads:[~2010-05-26 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 22:37 Pierre Muller
2010-05-25 21:01 ` Christopher Faylor
2010-05-26 8:07 ` Pierre Muller
2010-05-26 17:20 ` Christopher Faylor [this message]
2010-05-27 7:14 ` Pierre Muller
2010-05-27 12:59 ` Pierre Muller
2010-05-27 15:43 ` Christopher Faylor
2010-05-28 15:28 ` Pierre Muller
2010-05-30 18:00 ` Christopher Faylor
2010-06-01 6:57 ` [RFC] windows-nat.c: New oddity after copy console information for new console patch Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526170712.GA32594@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox