From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73306-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3872 invoked by alias); 26 May 2010 17:07:20 -0000
Received: (qmail 3860 invoked by uid 22791); 26 May 2010 17:07:18 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-173-76-55-5.bstnma.fios.verizon.net (HELO cgf.cx) (173.76.55.5)    by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Wed, 26 May 2010 17:07:14 +0000
Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5])	by cgf.cx (Postfix) with ESMTP id C052513C061;	Wed, 26 May 2010 13:07:12 -0400 (EDT)
Received: by ednor.cgf.cx (Postfix, from userid 201)	id BACFD2B352; Wed, 26 May 2010 13:07:12 -0400 (EDT)
Date: Wed, 26 May 2010 17:20:00 -0000
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org,	Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] windows-nat.c: Copy console information for new console
Message-ID: <20100526170712.GA32594@ednor.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org,	Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00599.txt.bz2

On Wed, May 26, 2010 at 09:49:05AM +0200, Pierre Muller wrote:
>> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] De la part de Christopher Faylor
>> I don't mind the concept but this function is becoming pretty big so I
>> would appreciate it if you would move all of the logic into a function.
>> Maybe call it "set_console_info()" and pass it &flags, &si.
>> 
>> cgf
>
>
>  You are right, this is cleaner, nevertheless flags isn't
>used much,

I actually thought fairly carefully about flags.  If you have a function
which controls console info, then the function should set the flags
appropriately to deal with the console info.

cgf