From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] windows-nat.c: Copy console information for new console
Date: Sun, 30 May 2010 18:00:00 -0000 [thread overview]
Message-ID: <20100530171041.GB8605@ednor.casa.cgf.cx> (raw)
In-Reply-To: <001201cafe4e$e885afa0$b9910ee0$@muller@ics-cnrs.unistra.fr>
On Fri, May 28, 2010 at 12:16:59PM +0200, Pierre Muller wrote:
>> >> From Christopher Faylor
>> >> I actually thought fairly carefully about flags. If you have a
>> >> function
>> >> which controls console info, then the function should set the flags
>> >> appropriately to deal with the console info.
>> >
>> >
>> > As you prefer,
>> >here is a new version that also takes DWORD *flags as parameter.
>> > I also tried to explain a little bit better
>> >what the function tries to do.
>>
>> Thanks. Looks good. I forgot to say: Thanks for doing this. It
>> looks like
>> a nice improvement.
>
> Hi Christopher,
> does this mean that you want to test it
>a little bit more before you give some more detailed
>review or should I understand this as an approval?
Wow. You like to go back and forth don't you?
Just apply it already.
cgf
next prev parent reply other threads:[~2010-05-30 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 22:37 Pierre Muller
2010-05-25 21:01 ` Christopher Faylor
2010-05-26 8:07 ` Pierre Muller
2010-05-26 17:20 ` Christopher Faylor
2010-05-27 7:14 ` Pierre Muller
2010-05-27 12:59 ` Pierre Muller
2010-05-27 15:43 ` Christopher Faylor
2010-05-28 15:28 ` Pierre Muller
2010-05-30 18:00 ` Christopher Faylor [this message]
2010-06-01 6:57 ` [RFC] windows-nat.c: New oddity after copy console information for new console patch Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530171041.GB8605@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox