Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [resubmit] gdb.base, r*.exp thru w*.exp
Date: Thu, 20 May 2010 21:28:00 -0000	[thread overview]
Message-ID: <20100520211446.GA8299@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4BF59BBB.8020603@vmware.com>

On Thu, 20 May 2010 22:29:47 +0200, Michael Snyder wrote:
> +	-re ".*in main after func1.*$gdb_prompt $" { 

Sorry for not a complete review but for this case there should be:

	-re ".*in main after func1.*\r\n$gdb_prompt $" { 

or lib/gdb.exp proc gdb_test is using:

	-re ".*in main after func1.*[\r\n]+$gdb_prompt $" { 

as just "$gdb_prompt $" is needlessly  weak in practical cases causing false
positives.


Thanks,
Jan


  parent reply	other threads:[~2010-05-20 21:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 21:01 Michael Snyder
2010-05-20 21:07 ` Joel Brobecker
2010-05-20 21:14   ` Michael Snyder
2010-05-20 21:28 ` Jan Kratochvil [this message]
2010-05-20 21:46   ` Michael Snyder
2010-05-20 21:47     ` Jan Kratochvil
2010-05-20 21:57       ` Michael Snyder
2010-05-20 22:02         ` Jan Kratochvil
2010-05-20 22:07           ` Michael Snyder
2010-05-20 22:07         ` Joel Brobecker
2010-05-20 22:21           ` Michael Snyder
2010-06-15 15:56 ` Frederic Riss
2010-06-15 16:19   ` Daniel Jacobowitz
2010-06-16  8:12     ` Frederic Riss
2010-06-18  0:23       ` Michael Snyder
2010-06-18  7:30         ` Frederic Riss
2010-06-15 17:44   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100520211446.GA8299@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox