From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [resubmit] gdb.base, r*.exp thru w*.exp
Date: Thu, 20 May 2010 22:21:00 -0000 [thread overview]
Message-ID: <4BF5B317.2000307@vmware.com> (raw)
In-Reply-To: <20100520220716.GH3019@adacore.com>
Joel Brobecker wrote:
>> Well, this is a very common and ancient idiom that is used
>> everywhere throughout the test suite.
>>
>> You have to assume that we don't care about anything between
>> the ".*" and the "$gdb_prompt $". If we do, the test is wrong,
>> but if it consumes more output than it was meant to, the
>> following tests will fail.
>
> To give more context about the whole effort, I have to say that this was
> one psychologically tough patch to review, because there are lots of
> little things that I would have wanted to improve. But Pedro is right
> that we should limit ourselves to semi-mechanical changes and not get
> carried away by trying to make things perfect. If the original test was
> already erroneous, we can fix that as a followup patch. That could be
> another mechanical patch...
>
Ditto. For instance, there are lots of places where I could
substitute your new "gdb_test_no_output" routine, but I am
refraining, unless I have to touch the test anyway.
You may note that I am using it for the "sevenbit" business.
next prev parent reply other threads:[~2010-05-20 22:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 21:01 Michael Snyder
2010-05-20 21:07 ` Joel Brobecker
2010-05-20 21:14 ` Michael Snyder
2010-05-20 21:28 ` Jan Kratochvil
2010-05-20 21:46 ` Michael Snyder
2010-05-20 21:47 ` Jan Kratochvil
2010-05-20 21:57 ` Michael Snyder
2010-05-20 22:02 ` Jan Kratochvil
2010-05-20 22:07 ` Michael Snyder
2010-05-20 22:07 ` Joel Brobecker
2010-05-20 22:21 ` Michael Snyder [this message]
2010-06-15 15:56 ` Frederic Riss
2010-06-15 16:19 ` Daniel Jacobowitz
2010-06-16 8:12 ` Frederic Riss
2010-06-18 0:23 ` Michael Snyder
2010-06-18 7:30 ` Frederic Riss
2010-06-15 17:44 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF5B317.2000307@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox