From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73157-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30223 invoked by alias); 20 May 2010 21:14:56 -0000
Received: (qmail 30215 invoked by uid 22791); 20 May 2010 21:14:56 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 May 2010 21:14:51 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4KLEoHA015160	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 20 May 2010 17:14:50 -0400
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4KLElbc013462	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Thu, 20 May 2010 17:14:49 -0400
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1])	by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o4KLElpD008539;	Thu, 20 May 2010 23:14:47 +0200
Received: (from jkratoch@localhost)	by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o4KLEknn008538;	Thu, 20 May 2010 23:14:46 +0200
Date: Thu, 20 May 2010 21:28:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [resubmit] gdb.base, r*.exp thru w*.exp
Message-ID: <20100520211446.GA8299@host0.dyn.jankratochvil.net>
References: <4BF59BBB.8020603@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BF59BBB.8020603@vmware.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00450.txt.bz2

On Thu, 20 May 2010 22:29:47 +0200, Michael Snyder wrote:
> +	-re ".*in main after func1.*$gdb_prompt $" { 

Sorry for not a complete review but for this case there should be:

	-re ".*in main after func1.*\r\n$gdb_prompt $" { 

or lib/gdb.exp proc gdb_test is using:

	-re ".*in main after func1.*[\r\n]+$gdb_prompt $" { 

as just "$gdb_prompt $" is needlessly  weak in practical cases causing false
positives.


Thanks,
Jan