Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [patch 1/3] Make obconcat use stdarg
Date: Fri, 07 May 2010 14:44:00 -0000	[thread overview]
Message-ID: <201005071443.o47EhDVi003960@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100507143102.GA14342@host0.dyn.jankratochvil.net> (message	from Jan Kratochvil on Fri, 7 May 2010 16:31:03 +0200)

> Date: Fri, 7 May 2010 16:31:03 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Tue, 04 May 2010 23:01:33 +0200, Mark Kettenis wrote:
> > > On Monday 03 May 2010 21:19:05, Mark Kettenis wrote:
> > > > 2010-05-03  Mark Kettenis  <kettenis@faure.sibelius.xs4all.nl>
> > > > 
> > > >         * remote.c (register_remote_support_xml)
> > > >         (remote_query_supported_append, remote_query_supported): Add cast
> > > >         to NULL used as sentinel.
> > > >         * tracepoint.c (tvariables_info_1): Likewise.
> > > >         * utils.c (add_internal_problem_command): Likewise.
> [...]
> > I added the missing spaces and committed the diff.  Thanks!
> 
> Assuming this remaining one is OK to check-in.

Sure!  Didn't hit that one on OpenBSD for obvious reasons ;).

> gdb/
> 2010-05-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* fbsd-nat.c (fbsd_make_corefile_notes): Add cast to NULL used as
> 	sentinel.
> 
> --- a/gdb/fbsd-nat.c
> +++ b/gdb/fbsd-nat.c
> @@ -208,7 +208,8 @@ fbsd_make_corefile_notes (bfd *obfd, int *note_size)
>        char *psargs = xstrdup (fname);
>  
>        if (get_inferior_args ())
> -	psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL);
> +	psargs = reconcat (psargs, psargs, " ", get_inferior_args (),
> +			   (char *) NULL);
>  
>        note_data = elfcore_write_prpsinfo (obfd, note_data, note_size,
>  					  fname, psargs);
> 


      parent reply	other threads:[~2010-05-07 14:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 18:16 Jan Kratochvil
2010-04-30 18:38 ` Tom Tromey
2010-04-30 19:07   ` Jan Kratochvil
2010-04-30 19:09 ` Mark Kettenis
2010-04-30 22:18   ` `sentinel' gcc-3.x/OpenBSD compat. [Re: [patch 1/3] Make obconcat use stdarg] Jan Kratochvil
2010-05-01  0:10     ` Pedro Alves
2010-05-02 12:04       ` [patch] ATTR_* -> ATTRIBUTE_* unification [Re: `sentinel' gcc-3.x/OpenBSD compat.] Jan Kratochvil
2010-05-02 15:33         ` Pedro Alves
2010-05-02 21:37           ` Jan Kratochvil
2010-05-02 23:20             ` [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification [Re: [patch] ATTR_* -> ATTRIBUTE_* unification] Jan Kratochvil
2010-05-02 23:42               ` Pedro Alves
2010-05-02 23:53                 ` Jan Kratochvil
2010-05-03  7:18                   ` Pierre Muller
2010-05-03  7:44                     ` Jan Kratochvil
2010-05-04  6:34                       ` Pierre Muller
2010-05-04 15:28                         ` Joel Brobecker
     [not found]                   ` <6652.26431233368$1272871093@news.gmane.org>
2010-05-03 18:15                     ` Tom Tromey
2010-05-01  6:07     ` `sentinel' gcc-3.x/OpenBSD compat. [Re: [patch 1/3] Make obconcat use stdarg] Eli Zaretskii
2010-05-02  6:49       ` Jan Kratochvil
2010-05-01  8:53     ` Mark Kettenis
2010-05-07 16:58       ` Jan Kratochvil
2010-05-07 22:34         ` Tom Tromey
2010-05-08  4:59           ` Jan Kratochvil
2010-05-02  7:52   ` [patch 1/3] Make obconcat use stdarg Jan Kratochvil
2010-05-03 18:25     ` Tom Tromey
2010-05-03 20:19     ` Mark Kettenis
2010-05-03 21:00       ` Pedro Alves
2010-05-04 21:03         ` Mark Kettenis
2010-05-07 14:31           ` Jan Kratochvil
2010-05-07 14:36             ` Pedro Alves
2010-05-07 14:44               ` Jan Kratochvil
2010-05-07 14:44             ` Mark Kettenis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005071443.o47EhDVi003960@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox