Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [patch] ATTR_* -> ATTRIBUTE_* unification  [Re: `sentinel' gcc-3.x/OpenBSD compat.]
Date: Sun, 02 May 2010 21:37:00 -0000	[thread overview]
Message-ID: <20100502213636.GA21869@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <201005021633.14850.pedro@codesourcery.com>

On Sun, 02 May 2010 17:33:14 +0200, Pedro Alves wrote:
> The GDB part looks fine to me.  Want to commit it separatelly to the
> GDBserver bit?

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2010-05/msg00011.html

Reintroduced back cli-out.c:cli_field_fmt's attr-format you have dropped by
`cli-out.c cleanup' today.


> If you don't feel like fixing this, I'll fix it after your patch is in.

Yes, please.  BTW I do not understand why gdb/gdbserver/ cannot use the common
infrastructure when even the doc states:
	In fact, a system that can run `gdbserver' to connect to a remote GDB
	could also run GDB locally!
I believe gdbserver/ provides less resources + features requiring code than
libiberty/ .


I will post some similar NORETURN + ATTR_NORETURN -> ATTRIBUTE_NORETURN.

Going to drop NORETURN as it is only for gcc < 2.7, ansidecl.h does not
support it and a missing noreturn flag can only affect code size, performance
and affect compilation diagnostics.


Thanks,
Jan


  reply	other threads:[~2010-05-02 21:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 18:16 [patch 1/3] Make obconcat use stdarg Jan Kratochvil
2010-04-30 18:38 ` Tom Tromey
2010-04-30 19:07   ` Jan Kratochvil
2010-04-30 19:09 ` Mark Kettenis
2010-04-30 22:18   ` `sentinel' gcc-3.x/OpenBSD compat. [Re: [patch 1/3] Make obconcat use stdarg] Jan Kratochvil
2010-05-01  0:10     ` Pedro Alves
2010-05-02 12:04       ` [patch] ATTR_* -> ATTRIBUTE_* unification [Re: `sentinel' gcc-3.x/OpenBSD compat.] Jan Kratochvil
2010-05-02 15:33         ` Pedro Alves
2010-05-02 21:37           ` Jan Kratochvil [this message]
2010-05-02 23:20             ` [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification [Re: [patch] ATTR_* -> ATTRIBUTE_* unification] Jan Kratochvil
2010-05-02 23:42               ` Pedro Alves
2010-05-02 23:53                 ` Jan Kratochvil
2010-05-03  7:18                   ` Pierre Muller
2010-05-03  7:44                     ` Jan Kratochvil
2010-05-04  6:34                       ` Pierre Muller
2010-05-04 15:28                         ` Joel Brobecker
     [not found]                   ` <6652.26431233368$1272871093@news.gmane.org>
2010-05-03 18:15                     ` Tom Tromey
2010-05-01  6:07     ` `sentinel' gcc-3.x/OpenBSD compat. [Re: [patch 1/3] Make obconcat use stdarg] Eli Zaretskii
2010-05-02  6:49       ` Jan Kratochvil
2010-05-01  8:53     ` Mark Kettenis
2010-05-07 16:58       ` Jan Kratochvil
2010-05-07 22:34         ` Tom Tromey
2010-05-08  4:59           ` Jan Kratochvil
2010-05-02  7:52   ` [patch 1/3] Make obconcat use stdarg Jan Kratochvil
2010-05-03 18:25     ` Tom Tromey
2010-05-03 20:19     ` Mark Kettenis
2010-05-03 21:00       ` Pedro Alves
2010-05-04 21:03         ` Mark Kettenis
2010-05-07 14:31           ` Jan Kratochvil
2010-05-07 14:36             ` Pedro Alves
2010-05-07 14:44               ` Jan Kratochvil
2010-05-07 14:44             ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100502213636.GA21869@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox