From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7164 invoked by alias); 2 May 2010 21:37:09 -0000 Received: (qmail 7156 invoked by uid 22791); 2 May 2010 21:37:08 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 May 2010 21:37:04 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o42Lar6Q010894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 May 2010 17:36:54 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o42LajHx032352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 May 2010 17:36:52 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o42Lagen022354; Sun, 2 May 2010 23:36:42 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o42Laaqt022351; Sun, 2 May 2010 23:36:36 +0200 Date: Sun, 02 May 2010 21:37:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [patch] ATTR_* -> ATTRIBUTE_* unification [Re: `sentinel' gcc-3.x/OpenBSD compat.] Message-ID: <20100502213636.GA21869@host0.dyn.jankratochvil.net> References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <201005010110.37403.pedro@codesourcery.com> <20100502120419.GA19249@host0.dyn.jankratochvil.net> <201005021633.14850.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201005021633.14850.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00020.txt.bz2 On Sun, 02 May 2010 17:33:14 +0200, Pedro Alves wrote: > The GDB part looks fine to me. Want to commit it separatelly to the > GDBserver bit? Checked-in: http://sourceware.org/ml/gdb-cvs/2010-05/msg00011.html Reintroduced back cli-out.c:cli_field_fmt's attr-format you have dropped by `cli-out.c cleanup' today. > If you don't feel like fixing this, I'll fix it after your patch is in. Yes, please. BTW I do not understand why gdb/gdbserver/ cannot use the common infrastructure when even the doc states: In fact, a system that can run `gdbserver' to connect to a remote GDB could also run GDB locally! I believe gdbserver/ provides less resources + features requiring code than libiberty/ . I will post some similar NORETURN + ATTR_NORETURN -> ATTRIBUTE_NORETURN. Going to drop NORETURN as it is only for gcc < 2.7, ansidecl.h does not support it and a missing noreturn flag can only affect code size, performance and affect compilation diagnostics. Thanks, Jan