From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72880-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31316 invoked by alias); 7 May 2010 14:44:58 -0000
Received: (qmail 31298 invoked by uid 22791); 7 May 2010 14:44:56 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 14:44:51 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o47EhElN025136;	Fri, 7 May 2010 16:43:14 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o47EhDVi003960;	Fri, 7 May 2010 16:43:13 +0200 (CEST)
Date: Fri, 07 May 2010 14:44:00 -0000
Message-Id: <201005071443.o47EhDVi003960@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
CC: pedro@codesourcery.com, gdb-patches@sourceware.org
In-reply-to: <20100507143102.GA14342@host0.dyn.jankratochvil.net> (message	from Jan Kratochvil on Fri, 7 May 2010 16:31:03 +0200)
Subject: Re: [patch 1/3] Make obconcat use stdarg
References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502075217.GA29039@host0.dyn.jankratochvil.net> <201005032019.o43KJ55C028671@glazunov.sibelius.xs4all.nl> <201005032200.14472.pedro@codesourcery.com> <201005042101.o44L1XWx030930@glazunov.sibelius.xs4all.nl> <20100507143102.GA14342@host0.dyn.jankratochvil.net>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00173.txt.bz2

> Date: Fri, 7 May 2010 16:31:03 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Tue, 04 May 2010 23:01:33 +0200, Mark Kettenis wrote:
> > > On Monday 03 May 2010 21:19:05, Mark Kettenis wrote:
> > > > 2010-05-03  Mark Kettenis  <kettenis@faure.sibelius.xs4all.nl>
> > > > 
> > > >         * remote.c (register_remote_support_xml)
> > > >         (remote_query_supported_append, remote_query_supported): Add cast
> > > >         to NULL used as sentinel.
> > > >         * tracepoint.c (tvariables_info_1): Likewise.
> > > >         * utils.c (add_internal_problem_command): Likewise.
> [...]
> > I added the missing spaces and committed the diff.  Thanks!
> 
> Assuming this remaining one is OK to check-in.

Sure!  Didn't hit that one on OpenBSD for obvious reasons ;).

> gdb/
> 2010-05-07  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* fbsd-nat.c (fbsd_make_corefile_notes): Add cast to NULL used as
> 	sentinel.
> 
> --- a/gdb/fbsd-nat.c
> +++ b/gdb/fbsd-nat.c
> @@ -208,7 +208,8 @@ fbsd_make_corefile_notes (bfd *obfd, int *note_size)
>        char *psargs = xstrdup (fname);
>  
>        if (get_inferior_args ())
> -	psargs = reconcat (psargs, psargs, " ", get_inferior_args (), NULL);
> +	psargs = reconcat (psargs, psargs, " ", get_inferior_args (),
> +			   (char *) NULL);
>  
>        note_data = elfcore_write_prpsinfo (obfd, note_data, note_size,
>  					  fname, psargs);
>