From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources
Date: Tue, 04 May 2010 15:38:00 -0000 [thread overview]
Message-ID: <20100504153752.GJ2768@adacore.com> (raw)
In-Reply-To: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr>
> Is this comment still valid, from the compiler point of view?
> Does gcc still have such problems?
I don't know.
> If yes, is it OK if I remove all ATTRIBUTE_UNUSED from sources?
> If no, shouldn't we change that policy?
I haven't thought much about it but, to me ATTRIBUTE_UNUSED does not
make sense unless we use -Wunused-param. And I really don't see how
this switch could help us increase code quality - only extra hassle
trying to silence warnings. We have so many functions used as callbacks
with defined APIs that we probably have unused parameters everywhere.
So, at this point, I'm leaning towards getting rid of ATTRIBUTE_UNUSED
and keeping the ARI (or perhaps poison it too).
--
Joel
next prev parent reply other threads:[~2010-05-04 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 13:49 Pierre Muller
2010-05-04 15:38 ` Joel Brobecker [this message]
2010-05-04 16:05 ` [RFA] Get rid " Pierre Muller
2010-05-05 14:42 ` Joel Brobecker
2010-05-05 15:09 ` Pierre Muller
2010-05-04 16:23 ` [ARI] Status " Jan Kratochvil
2010-05-04 20:59 ` Pierre Muller
2010-05-04 21:15 ` Jan Kratochvil
2010-05-05 14:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504153752.GJ2768@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox