From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9356 invoked by alias); 4 May 2010 15:38:13 -0000 Received: (qmail 9327 invoked by uid 22791); 4 May 2010 15:38:12 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 15:38:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6461C2BAB30; Tue, 4 May 2010 11:38:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TCo9thEUqp1j; Tue, 4 May 2010 11:38:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 328A22BAB2A; Tue, 4 May 2010 11:38:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 20450F58F9; Tue, 4 May 2010 08:37:52 -0700 (PDT) Date: Tue, 04 May 2010 15:38:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources Message-ID: <20100504153752.GJ2768@adacore.com> References: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00069.txt.bz2 > Is this comment still valid, from the compiler point of view? > Does gcc still have such problems? I don't know. > If yes, is it OK if I remove all ATTRIBUTE_UNUSED from sources? > If no, shouldn't we change that policy? I haven't thought much about it but, to me ATTRIBUTE_UNUSED does not make sense unless we use -Wunused-param. And I really don't see how this switch could help us increase code quality - only extra hassle trying to silence warnings. We have so many functions used as callbacks with defined APIs that we probably have unused parameters everywhere. So, at this point, I'm leaning towards getting rid of ATTRIBUTE_UNUSED and keeping the ARI (or perhaps poison it too). -- Joel