From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Jan Kratochvil'" <jan.kratochvil@redhat.com>,
"'Joel Brobecker'" <brobecker@adacore.com>
Cc: <gdb@sourceware.org>, <gdb-patches@sourceware.org>
Subject: RE: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources
Date: Tue, 04 May 2010 20:59:00 -0000 [thread overview]
Message-ID: <005201caebcc$9ea723d0$dbf56b70$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <20100504162233.GA1910@host0.dyn.jankratochvil.net>
> -----Message d'origine-----
> De : gdb-owner@sourceware.org [mailto:gdb-owner@sourceware.org] De la
> part de Jan Kratochvil
> Envoyé : Tuesday, May 04, 2010 6:23 PM
> À : Joel Brobecker
> Cc : Pierre Muller; gdb@sourceware.org; gdb-patches@sourceware.org
> Objet : Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources
>
> On Tue, 04 May 2010 17:37:52 +0200, Joel Brobecker wrote:
> > make sense unless we use -Wunused-param. And I really don't see how
> > this switch could help us increase code quality - only extra hassle
> > trying to silence warnings.
>
> While I agree ATTRIBUTE_UNUSED is more hassle than benefit I have to
> bring up
> recently -Wunused-param would catch a real bug in an Archer patch
> (missing "bp->thread = tp->num;"):
> http://sourceware.org/ml/archer/2010-q2/msg00017.html
Did you really use -Wunused-param to catch this,
or is it just a case where it could have been useful
to have this warning?
I found no easy way to add some extra -Wunused option to
the compiler flags...
Adding it to CFLAGS has no effects as there is a -Wno-unused
inside WARN_CFLAGS ...
Maybe we could add a EXTRA_WARN_CFLAGS to Makefile.in
Pierre
next prev parent reply other threads:[~2010-05-04 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 13:49 Pierre Muller
2010-05-04 15:38 ` Joel Brobecker
2010-05-04 16:05 ` [RFA] Get rid " Pierre Muller
2010-05-05 14:42 ` Joel Brobecker
2010-05-05 15:09 ` Pierre Muller
2010-05-04 16:23 ` [ARI] Status " Jan Kratochvil
2010-05-04 20:59 ` Pierre Muller [this message]
2010-05-04 21:15 ` Jan Kratochvil
2010-05-05 14:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005201caebcc$9ea723d0$dbf56b70$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox