From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15505 invoked by alias); 4 May 2010 20:59:37 -0000 Received: (qmail 15489 invoked by uid 22791); 4 May 2010 20:59:36 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 20:59:31 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44KwtTt005646 ; Tue, 4 May 2010 22:58:56 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o44KwsG1074507 ; Tue, 4 May 2010 22:58:54 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o44KwrHG023666 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 4 May 2010 22:58:53 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Jan Kratochvil'" , "'Joel Brobecker'" Cc: , References: <002701caeb90$894ad040$9be070c0$@muller@ics-cnrs.unistra.fr> <20100504153752.GJ2768@adacore.com> <20100504162233.GA1910@host0.dyn.jankratochvil.net> In-Reply-To: <20100504162233.GA1910@host0.dyn.jankratochvil.net> Subject: RE: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources Date: Tue, 04 May 2010 20:59:00 -0000 Message-ID: <005201caebcc$9ea723d0$dbf56b70$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00077.txt.bz2 > -----Message d'origine----- > De=A0: gdb-owner@sourceware.org [mailto:gdb-owner@sourceware.org] De la > part de Jan Kratochvil > Envoy=E9=A0: Tuesday, May 04, 2010 6:23 PM > =C0=A0: Joel Brobecker > Cc=A0: Pierre Muller; gdb@sourceware.org; gdb-patches@sourceware.org > Objet=A0: Re: [ARI] Status of ATTRIBUTE_UNUSED in gdb sources >=20 > On Tue, 04 May 2010 17:37:52 +0200, Joel Brobecker wrote: > > make sense unless we use -Wunused-param. And I really don't see how > > this switch could help us increase code quality - only extra hassle > > trying to silence warnings. >=20 > While I agree ATTRIBUTE_UNUSED is more hassle than benefit I have to > bring up > recently -Wunused-param would catch a real bug in an Archer patch > (missing "bp->thread =3D tp->num;"): > http://sourceware.org/ml/archer/2010-q2/msg00017.html Did you really use -Wunused-param to catch this, or is it just a case where it could have been useful=20 to have this warning? I found no easy way to add some extra -Wunused option to the compiler flags... Adding it to CFLAGS has no effects as there is a -Wno-unused inside WARN_CFLAGS ... Maybe we could add a EXTRA_WARN_CFLAGS to Makefile.in Pierre=20