Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: unify target->subdir handling for default tests
Date: Thu, 22 Apr 2010 02:03:00 -0000	[thread overview]
Message-ID: <201004212203.45943.vapier@gentoo.org> (raw)
In-Reply-To: <t2ye394668d1004211532q92d9a422g39cdd5fc1c1264ce@mail.gmail.com>

[-- Attachment #1: Type: Text/Plain, Size: 1836 bytes --]

On Wednesday 21 April 2010 18:32:22 Doug Evans wrote:
> How have you tested it?
> [I'd test it on at least two targets, if not more.]

i do most development against the Blackfin port, but i wrote a small script to 
build/test all known working targets, and these all pass for me (which is to 
say, there are actually tests that get compiled/run in their respective sim):
arm frv sh v850
emphasis is that i can now do `make check` for any target without having to 
set up dejagnu in any way.

the attached patch removes the workaround in the mips testsuite so that it too 
works out of the box.

these targets also pass, but they lack any sort of testsuite (who does that?), 
so that isnt saying much:
avr m32c	mn10300 moxie ppc rx

h8300 fails a few tests, but that appears to be a bug in its assembler while 
running on 64bit hosts.  the rest pass fine.

cr16 fails horribly, but it seems to be a bug in its own testsuite (every link 
warns about missing entry point and the sim framework interprets that as a 
failure).

as for the remaining targets, they dont even build for me for various reasons 
for which i blame them ;).
-mike

RCS file: /cvs/src/src/sim/testsuite/sim/mips/basic.exp,v
retrieving revision 1.9
diff -u -p -r1.9 basic.exp
--- sim/testsuite/sim/mips/basic.exp	20 Feb 2007 13:28:55 -0000	1.9
+++ sim/testsuite/sim/mips/basic.exp	22 Apr 2010 02:01:32 -0000
@@ -32,9 +32,8 @@ proc run_hilo_test {testfile models nops
 }
 
 
-# Only test mips*-*-elf (e.g., no mips*-*-linux), and only test if the target
-# board really is a simulator (sim tests don't work on real HW).
-if {[istarget mips*-*-elf] && [board_info target exists is_simulator]} {
+# Only test mips*-*-elf (e.g., no mips*-*-linux)
+if {[istarget mips*-*-elf]} {
 
     set dspmodels ""
     set mdmxmodels ""

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-04-22  2:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 21:12 Mike Frysinger
2010-04-21 22:32 ` Doug Evans
2010-04-22  2:03   ` Mike Frysinger [this message]
2010-04-22  2:26     ` Mike Frysinger
2010-04-22  2:06   ` Mike Frysinger
2010-04-26 16:24 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004212203.45943.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox