From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31552 invoked by alias); 22 Apr 2010 02:03:41 -0000 Received: (qmail 31498 invoked by uid 22791); 22 Apr 2010 02:03:37 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_MX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 02:03:17 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id CF4DD1B4013; Thu, 22 Apr 2010 02:03:14 +0000 (UTC) From: Mike Frysinger To: Doug Evans Subject: Re: [PATCH] sim: unify target->subdir handling for default tests Date: Thu, 22 Apr 2010 02:03:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.2; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1271884330-28781-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2224833.8epSRKX1fX"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201004212203.45943.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00729.txt.bz2 --nextPart2224833.8epSRKX1fX Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1836 On Wednesday 21 April 2010 18:32:22 Doug Evans wrote: > How have you tested it? > [I'd test it on at least two targets, if not more.] i do most development against the Blackfin port, but i wrote a small script= to=20 build/test all known working targets, and these all pass for me (which is t= o=20 say, there are actually tests that get compiled/run in their respective sim= ): arm frv sh v850 emphasis is that i can now do `make check` for any target without having to= =20 set up dejagnu in any way. the attached patch removes the workaround in the mips testsuite so that it = too=20 works out of the box. these targets also pass, but they lack any sort of testsuite (who does that= ?),=20 so that isnt saying much: avr m32c mn10300 moxie ppc rx h8300 fails a few tests, but that appears to be a bug in its assembler whil= e=20 running on 64bit hosts. the rest pass fine. cr16 fails horribly, but it seems to be a bug in its own testsuite (every l= ink=20 warns about missing entry point and the sim framework interprets that as a= =20 failure). as for the remaining targets, they dont even build for me for various reaso= ns=20 for which i blame them ;). -mike RCS file: /cvs/src/src/sim/testsuite/sim/mips/basic.exp,v retrieving revision 1.9 diff -u -p -r1.9 basic.exp --- sim/testsuite/sim/mips/basic.exp 20 Feb 2007 13:28:55 -0000 1.9 +++ sim/testsuite/sim/mips/basic.exp 22 Apr 2010 02:01:32 -0000 @@ -32,9 +32,8 @@ proc run_hilo_test {testfile models nops } =20 =20 -# Only test mips*-*-elf (e.g., no mips*-*-linux), and only test if the tar= get -# board really is a simulator (sim tests don't work on real HW). -if {[istarget mips*-*-elf] && [board_info target exists is_simulator]} { +# Only test mips*-*-elf (e.g., no mips*-*-linux) +if {[istarget mips*-*-elf]} { =20 set dspmodels "" set mdmxmodels "" --nextPart2224833.8epSRKX1fX Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLz66BAAoJEEFjO5/oN/WBDr4P/0PekJBE5ODcejZhOAHzsrVj J+rM7VctgJzAIsbFncfeGjR4SNpCkGHVXajEXhd66GaI0l1wWa/clpDzW5XCw7ZI PkRHDWx2LRUT901+WpKFcqBv8dfapituRY/2qwQ6RFkLVrpr4K5Xad3qMKbb4z1O cctdtiluo+aZh83VNwqa6ZgPujMhU8Cg9DD8E5ufXuCOQV+zlxCIsh6t8jNG7hjp jpERpJHmRmaC7yeF/jyvprI4VNvKaKjgcXmvIcdFzieKP6UyRkHF27pGGwEaPcAi CTcQqmym1TW1o3aaZ1Ldb3auIWEFvYuuZXwsz1LMczwPdWlINgIC9r0wZmBMo4Pk P6PklTZtXh5ne2VkqmHq256FxjKmrw2igmB9E4Hceyo5BBPmEaBhU2/A7olADqJc GOapFAacMmS8rgWqiN6ZjOfmbfVqKZZfDPVFd6SiivpsA/n3d6F/dEe+xaQOwnRe 9ALvH1vRqTjAR8482dfxfyze5vqF2Sd1hty7unt2SCf/K3w5vqmer1We3PJs4mPZ Aiu6i/YIsctlb+p89ASocaiUkdlCHYhIz58XtjskFcfvJgpf7WCacEGj3yY7SKW5 JB37FLJsrVwXzliIjSLJ7m8/XjIF67hRDjHIIO5JkQgvkq0ALyIm8CxbyjaxyPG0 F82jKjDvXSSr/O0K/MGy =SHop -----END PGP SIGNATURE----- --nextPart2224833.8epSRKX1fX--