From: Doug Evans <dje@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: unify target->subdir handling for default tests
Date: Wed, 21 Apr 2010 22:32:00 -0000 [thread overview]
Message-ID: <t2ye394668d1004211532q92d9a422g39cdd5fc1c1264ce@mail.gmail.com> (raw)
In-Reply-To: <1271884330-28781-1-git-send-email-vapier@gentoo.org>
On Wed, Apr 21, 2010 at 2:12 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> The testsuite subdir has a note about unifying the target->subdir logic,
> so do just that. The end goal here is to have `make check` work out of
> the box without having to delve into dejagnu internals.
>
> The target-specific logic is split out of the top level configure.ac file
> and into a dedicated configure.tgt similar to other subprojects (gdb and
> ld and etc...) with the difference that this file has to be included at
> the m4 level instead of the shell level. This is necessary only because
> autoconf requires AC_CONFIG_SUBDIRS be given a string literal and not a
> variable value.
>
> Then the toplevel and the testsuite configure files pull this in, the sim
> subdir gets expanded into testsuite/site.exp, and the default sim run code
> uses this info to set the sim path to the local compiled run file if it
> hasn't already been specified.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> sim/:
> 2010-04-21 Mike Frysinger <vapier@gentoo.org>
>
> * configure.ac: Target logic moved out to and included from ...
> * configure.tgt: ... this new file.
> * configure: Regenerated.
>
> sim/testsuite/:
> 2010-04-21 Mike Frysinger <vapier@gentoo.org>
>
> * Makefile.in (arch): Set to @sim_arch@.
> * configure.ac: Delete arch logic and include ../configure.tgt.
> * configure: Regenerated.
> * lib/sim-defs.exp (sim_run): Default sim to ../arch/run.
> ---
> sim/configure.ac | 120 +++-------------------------------------
> sim/configure.tgt | 114 ++++++++++++++++++++++++++++++++++++++
> sim/testsuite/Makefile.in | 2 +-
> sim/testsuite/configure.ac | 8 +--
> sim/testsuite/lib/sim-defs.exp | 9 +++
> 5 files changed, 133 insertions(+), 120 deletions(-)
> create mode 100644 sim/configure.tgt
>
This is ok with me with a few qualifications.
I'd leave it for a few days to see if anyone else wants to comment.
I'd add a comment to configure.tgt saying that it's intended to be m4-included.
[It's kinda clear since a few lines in there's an m4 command :-), but
an explicit comment would help, I think.]
How have you tested it?
[I'd test it on at least two targets, if not more.]
next prev parent reply other threads:[~2010-04-21 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 21:12 Mike Frysinger
2010-04-21 22:32 ` Doug Evans [this message]
2010-04-22 2:03 ` Mike Frysinger
2010-04-22 2:26 ` Mike Frysinger
2010-04-22 2:06 ` Mike Frysinger
2010-04-26 16:24 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=t2ye394668d1004211532q92d9a422g39cdd5fc1c1264ce@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox