Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tristan Gingold <gingold@adacore.com>,
	 Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/commit] Check library name rather than member name when rereading symbols.
Date: Wed, 21 Apr 2010 15:58:00 -0000	[thread overview]
Message-ID: <201004211658.18223.pedro@codesourcery.com> (raw)
In-Reply-To: <08697AC4-EB29-4F1B-BF7F-86EF17945F92@adacore.com>

On Wednesday 21 April 2010 16:43:43, Tristan Gingold wrote:
> > Makes sense to me.  And it's wonderful to get rid of another
> > #ifdef DEPRECATED_IBM6000_TARGET instance.  Though, isn't the
> > comment's mention of "shared" a bit misleading?  Isn't this about static
> > libraries / archives?  Does this really also apply to shared
> > libraries?
> 
> For darwin, this applies only to static libraries.  For AIX, I don't know :-)

Found it, I think:

<http://publib.boulder.ibm.com/infocenter/comphelp/v7v91/index.jsp?topic=/com.ibm.vacpp7a.doc/getstart/overview/port_aix_obj_lib.htm>

 "A shared library on AIX refers to an archive library file created by the ar
 command, in which one or more of the archive members is a shared object."

So, could you tweak the comment a bit while there?  I'd suggest:

/* If this object is from an archive (what you usually create with
   `ar', often called a `static library' on most systems, though
   a `shared library' on AIX is also an archive), then you should
   stat on the archive name, not member name.  */

Thanks.

-- 
Pedro Alves


  reply	other threads:[~2010-04-21 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 15:18 Joel Brobecker
2010-04-21 15:40 ` Pedro Alves
2010-04-21 15:43   ` Tristan Gingold
2010-04-21 15:58     ` Pedro Alves [this message]
2010-04-21 16:12       ` Joel Brobecker
2010-04-27 21:06         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004211658.18223.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox