Re: [RFA/commit] Check library name rather than member name when rereading symbols.

[Joel Brobecker <brobecker@adacore.com>]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

> So, could you tweak the comment a bit while there?  I'd suggest:
> 
> /* If this object is from an archive (what you usually create with
>    `ar', often called a `static library' on most systems, though
>    a `shared library' on AIX is also an archive), then you should
>    stat on the archive name, not member name.  */

Absolutely - thanks for digging out the info. Here is an updated version...

-- 
Joel

[-- Attachment #2: symfile.diff --]
[-- Type: text/x-diff, Size: 2176 bytes --]

commit f747aae3d5099a7e4c294b2b62e10346e561a5a6
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Tue Apr 20 14:13:34 2010 -0400

    Check library name rather than member name when rereading symbols.
    
    On Darwin, we have lots of complaints being emitted when restarting
    a program:
    
        (gdb) start
        `a-except.o' has disappeared; keeping its symbols.
        `unwind-dw2.o' has disappeared; keeping its symbols.
        `s-except.o' has disappeared; keeping its symbols.
        `s-traceb.o' has disappeared; keeping its symbols.
    
    These object files are part of the GNAT runtime, and were never available.
    The warning comes from the fact that we're checking whether the .o files
    in the GNAT shared runtime have changed whereas we should be checking
    whether the GNAT shared library itself has changed.
    
    This patch implements this.  Although it is really only useful on a platform
    such as Darwin (debug info stored in .o files), we believe that this is
    the right thing to do in general.  This change should be a noop for all
    the other platforms in any case.
    
    gdb/ChangeLog (from Tristan Gingold & Pedro Alves):
    
            * symfile.c (reread_symbols): Also search for file in libraries.
            Update comment.
    
    Tested on x86_64-darwin and x86_64-linux.

diff --git a/gdb/symfile.c b/gdb/symfile.c
index eda26cc..d11069c 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2291,14 +2291,13 @@ reread_symbols (void)
       if (objfile->separate_debug_objfile_backlink)
 	continue;
 
-#ifdef DEPRECATED_IBM6000_TARGET
-      /* If this object is from a shared library, then you should
-	 stat on the library name, not member name. */
-
+      /* If this object is from an archive (what you usually create with
+	 `ar', often called a `static library' on most systems, though
+	 a `shared library' on AIX is also an archive), then you should
+	 stat on the archive name, not member name.  */
       if (objfile->obfd->my_archive)
 	res = stat (objfile->obfd->my_archive->filename, &new_statbuf);
       else
-#endif
 	res = stat (objfile->name, &new_statbuf);
       if (res != 0)
 	{