From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22152 invoked by alias); 21 Apr 2010 15:58:35 -0000 Received: (qmail 22137 invoked by uid 22791); 21 Apr 2010 15:58:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 15:58:27 +0000 Received: (qmail 7181 invoked from network); 21 Apr 2010 15:58:25 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Apr 2010 15:58:25 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Check library name rather than member name when rereading symbols. Date: Wed, 21 Apr 2010 15:58:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: Tristan Gingold , Joel Brobecker References: <1271863083-15509-1-git-send-email-brobecker@adacore.com> <201004211640.21421.pedro@codesourcery.com> <08697AC4-EB29-4F1B-BF7F-86EF17945F92@adacore.com> In-Reply-To: <08697AC4-EB29-4F1B-BF7F-86EF17945F92@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004211658.18223.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00688.txt.bz2 On Wednesday 21 April 2010 16:43:43, Tristan Gingold wrote: > > Makes sense to me. And it's wonderful to get rid of another > > #ifdef DEPRECATED_IBM6000_TARGET instance. Though, isn't the > > comment's mention of "shared" a bit misleading? Isn't this about static > > libraries / archives? Does this really also apply to shared > > libraries? > > For darwin, this applies only to static libraries. For AIX, I don't know :-) Found it, I think: "A shared library on AIX refers to an archive library file created by the ar command, in which one or more of the archive members is a shared object." So, could you tweak the comment a bit while there? I'd suggest: /* If this object is from an archive (what you usually create with `ar', often called a `static library' on most systems, though a `shared library' on AIX is also an archive), then you should stat on the archive name, not member name. */ Thanks. -- Pedro Alves