Re: [PATCH] gdb: workaround sparc memcpy fortify error

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=BAYES_00,TW_CP,TW_EG
> X-Spam-Check-By: sourceware.org
> Date: Wed, 21 Apr 2010 12:01:41 -0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
> Content-Disposition: inline
> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
> Sender: gdb-patches-owner@sourceware.org
> X-XS4ALL-DNSBL-Checked: mxdrop118.xs4all.nl checked 209.132.180.131 against DNS blacklists
> X-CNFS-Analysis: v=1.1 cv=a8sYchbnJd2dMYUqqjolUMD0rF/qLqJCTuzWyWz0xZo= c=1
> 	sm=0 a=_NDgYHZHEuYA:10 a=ORa4HqFjfvEA:10 a=kj9zAlcOel0A:10
> 	a=vbYRN7G9ZuyAWxq09MFwFw==:17 a=TSbVqHtbAAAA:8 a=7mOBRU54AAAA:8
> 	a=v8Wh4-vryUNciPy22swA:9 a=PQkedLpdK-Zry27wWXRhssVy98EA:4
> 	a=CjuIK1q_8ugA:10 a=6pLrmOwY6VMA:10 a=vbYRN7G9ZuyAWxq09MFwFw==:117
> X-Virus-Scanned: by XS4ALL Virus Scanner
> X-XS4ALL-Spam-Score: 0.0 () none
> X-XS4ALL-Spam: NO
> Envelope-To: m.m.kettenis@xs4all.nl
> 
> > Joel> ENOPATCH?
> > 
> > It was a ping for http://permalink.gmane.org/gmane.comp.gdb.patches/56350
> 
> Aha - Mark Kettenis seemed to be OK with this, since he's the one
> who suggested it. Mark, is this patch still OK?

Hmm, can we keep the existing gdb_assert() and just add the len <= 8
one?  With that change, this is fine with me.

> 2010-03-19  Mike Frysinger  <vapier <at> gentoo.org>
> 
>         * gdb/sparc-tdep.c (sparc32_store_return_value): Change gdb_assert ()
>         to len <= 8.
> 
> gdb/sparc-tdep.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c
> index f129a55..ab45ddd 100644
> --- a/gdb/sparc-tdep.c
> +++ b/gdb/sparc-tdep.c
> @@ -1062,7 +1062,7 @@ sparc32_extract_return_value (struct type *type, struct regcache *regcache,
>    gdb_byte buf[8];
> 
>    gdb_assert (!sparc_structure_or_union_p (type));
> -  gdb_assert (!(sparc_floating_p (type) && len == 16));
> +  gdb_assert (len <= 8);
> 
>    if (sparc_floating_p (type))
>      {
> 
> -- 
> Joel
>