Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: kettenis@gnu.org
Cc: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: workaround sparc memcpy fortify error
Date: Wed, 21 Apr 2010 16:01:00 -0000	[thread overview]
Message-ID: <20100421160141.GB19194@adacore.com> (raw)
In-Reply-To: <m3hbn4byuq.fsf@fleche.redhat.com>

> Joel> ENOPATCH?
> 
> It was a ping for http://permalink.gmane.org/gmane.comp.gdb.patches/56350

Aha - Mark Kettenis seemed to be OK with this, since he's the one
who suggested it. Mark, is this patch still OK?

2010-03-19  Mike Frysinger  <vapier <at> gentoo.org>

        * gdb/sparc-tdep.c (sparc32_store_return_value): Change gdb_assert ()
        to len <= 8.

gdb/sparc-tdep.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c
index f129a55..ab45ddd 100644
--- a/gdb/sparc-tdep.c
+++ b/gdb/sparc-tdep.c
@@ -1062,7 +1062,7 @@ sparc32_extract_return_value (struct type *type, struct regcache *regcache,
   gdb_byte buf[8];

   gdb_assert (!sparc_structure_or_union_p (type));
-  gdb_assert (!(sparc_floating_p (type) && len == 16));
+  gdb_assert (len <= 8);

   if (sparc_floating_p (type))
     {

-- 
Joel


  reply	other threads:[~2010-04-21 16:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19  2:09 [PATCH] gdb: fix " Mike Frysinger
2010-03-19  7:45 ` Eli Zaretskii
2010-03-19  8:18   ` Hui Zhu
2010-03-19  8:42     ` Andreas Schwab
2010-03-19 17:10     ` Mike Frysinger
2010-03-19  9:26 ` Mark Kettenis
2010-03-19 17:09   ` Mike Frysinger
2010-03-19 20:11 ` [PATCH] gdb: workaround " Mike Frysinger
2010-04-19 18:59   ` Mike Frysinger
2010-04-21 15:30     ` Joel Brobecker
2010-04-21 15:38       ` Tom Tromey
2010-04-21 16:01         ` Joel Brobecker [this message]
2010-04-21 16:10           ` Mark Kettenis
2010-04-21 19:40             ` Mike Frysinger
2010-04-21 19:56               ` Mark Kettenis
2010-04-21 20:12                 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421160141.GB19194@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kettenis@gnu.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox