From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29727 invoked by alias); 21 Apr 2010 16:01:51 -0000 Received: (qmail 29660 invoked by uid 22791); 21 Apr 2010 16:01:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=BAYES_00,TW_CP,TW_EG X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 16:01:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 068B62BAC7A; Wed, 21 Apr 2010 12:01:43 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LcYjk9Elhi31; Wed, 21 Apr 2010 12:01:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4AE902BAB60; Wed, 21 Apr 2010 12:01:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D72B3F5895; Wed, 21 Apr 2010 09:01:41 -0700 (PDT) Date: Wed, 21 Apr 2010 16:01:00 -0000 From: Joel Brobecker To: kettenis@gnu.org Cc: Mike Frysinger , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: workaround sparc memcpy fortify error Message-ID: <20100421160141.GB19194@adacore.com> References: <1268964549-30380-1-git-send-email-vapier@gentoo.org> <1269029490-6943-1-git-send-email-vapier@gentoo.org> <201004191458.55123.vapier@gentoo.org> <20100421153010.GZ19194@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00689.txt.bz2 > Joel> ENOPATCH? > > It was a ping for http://permalink.gmane.org/gmane.comp.gdb.patches/56350 Aha - Mark Kettenis seemed to be OK with this, since he's the one who suggested it. Mark, is this patch still OK? 2010-03-19 Mike Frysinger gentoo.org> * gdb/sparc-tdep.c (sparc32_store_return_value): Change gdb_assert () to len <= 8. gdb/sparc-tdep.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c index f129a55..ab45ddd 100644 --- a/gdb/sparc-tdep.c +++ b/gdb/sparc-tdep.c @@ -1062,7 +1062,7 @@ sparc32_extract_return_value (struct type *type, struct regcache *regcache, gdb_byte buf[8]; gdb_assert (!sparc_structure_or_union_p (type)); - gdb_assert (!(sparc_floating_p (type) && len == 16)); + gdb_assert (len <= 8); if (sparc_floating_p (type)) { -- Joel