From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6919 invoked by alias); 21 Apr 2010 16:10:55 -0000 Received: (qmail 6661 invoked by uid 22791); 21 Apr 2010 16:10:52 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=BAYES_00,TW_CP,TW_EG,TW_ZM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 16:10:45 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3LG8tIo004297; Wed, 21 Apr 2010 18:08:55 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3LG8rNo016697; Wed, 21 Apr 2010 18:08:54 +0200 (CEST) Date: Wed, 21 Apr 2010 16:10:00 -0000 Message-Id: <201004211608.o3LG8rNo016697@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: vapier@gentoo.org, gdb-patches@sourceware.org In-reply-to: <20100421160141.GB19194@adacore.com> (message from Joel Brobecker on Wed, 21 Apr 2010 12:01:41 -0400) Subject: Re: [PATCH] gdb: workaround sparc memcpy fortify error References: <1268964549-30380-1-git-send-email-vapier@gentoo.org> <1269029490-6943-1-git-send-email-vapier@gentoo.org> <201004191458.55123.vapier@gentoo.org> <20100421153010.GZ19194@adacore.com> <20100421160141.GB19194@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00690.txt.bz2 > X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=BAYES_00,TW_CP,TW_EG > X-Spam-Check-By: sourceware.org > Date: Wed, 21 Apr 2010 12:01:41 -0400 > From: Joel Brobecker > Cc: Mike Frysinger , gdb-patches@sourceware.org > Content-Disposition: inline > Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm > Sender: gdb-patches-owner@sourceware.org > X-XS4ALL-DNSBL-Checked: mxdrop118.xs4all.nl checked 209.132.180.131 against DNS blacklists > X-CNFS-Analysis: v=1.1 cv=a8sYchbnJd2dMYUqqjolUMD0rF/qLqJCTuzWyWz0xZo= c=1 > sm=0 a=_NDgYHZHEuYA:10 a=ORa4HqFjfvEA:10 a=kj9zAlcOel0A:10 > a=vbYRN7G9ZuyAWxq09MFwFw==:17 a=TSbVqHtbAAAA:8 a=7mOBRU54AAAA:8 > a=v8Wh4-vryUNciPy22swA:9 a=PQkedLpdK-Zry27wWXRhssVy98EA:4 > a=CjuIK1q_8ugA:10 a=6pLrmOwY6VMA:10 a=vbYRN7G9ZuyAWxq09MFwFw==:117 > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: 0.0 () none > X-XS4ALL-Spam: NO > Envelope-To: m.m.kettenis@xs4all.nl > > > Joel> ENOPATCH? > > > > It was a ping for http://permalink.gmane.org/gmane.comp.gdb.patches/56350 > > Aha - Mark Kettenis seemed to be OK with this, since he's the one > who suggested it. Mark, is this patch still OK? Hmm, can we keep the existing gdb_assert() and just add the len <= 8 one? With that change, this is fine with me. > 2010-03-19 Mike Frysinger gentoo.org> > > * gdb/sparc-tdep.c (sparc32_store_return_value): Change gdb_assert () > to len <= 8. > > gdb/sparc-tdep.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/sparc-tdep.c b/gdb/sparc-tdep.c > index f129a55..ab45ddd 100644 > --- a/gdb/sparc-tdep.c > +++ b/gdb/sparc-tdep.c > @@ -1062,7 +1062,7 @@ sparc32_extract_return_value (struct type *type, struct regcache *regcache, > gdb_byte buf[8]; > > gdb_assert (!sparc_structure_or_union_p (type)); > - gdb_assert (!(sparc_floating_p (type) && len == 16)); > + gdb_assert (len <= 8); > > if (sparc_floating_p (type)) > { > > -- > Joel >