From: Pedro Alves <pedro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [v3] PR8554: New command to save breakpoints to a file
Date: Mon, 19 Apr 2010 17:07:00 -0000 [thread overview]
Message-ID: <201004191807.01058.pedro@codesourcery.com> (raw)
In-Reply-To: <20100419161631.GS19194@adacore.com>
On Monday 19 April 2010 17:16:31, Joel Brobecker wrote:
> I think this is awesome. I hope this gets checked in soon, as I'm sure
> many users will be glad to use it.
Sorry, I had committed it yesterday evening/night, after Eli's docs
approval, and got distracted by other things (including sleeping)
and didn't get back here to say it explicitly. You'd have seen it had
you been subscribed to gdb-cvs, though. ;-)
>
> > + case ex_catch_exception_unhandled:
> > + fprintf_filtered (fp, "catch unhandled");
> > + break;
>
> Just one nit: The right command is actually "catch exception unhandled".
Ah, thanks, missed that. I went ahead and applied the fix below.
--
Pedro Alves
2010-04-19 Pedro Alves <pedro@codesourcery.com>
* ada-lang.c (print_recreate_exception)
<ex_catch_exception_unhandled>: It's "catch exception unhandled",
not "catch unhandled".
---
gdb/ada-lang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: src/gdb/ada-lang.c
===================================================================
--- src.orig/gdb/ada-lang.c 2010-04-19 17:58:47.000000000 +0100
+++ src/gdb/ada-lang.c 2010-04-19 17:59:06.000000000 +0100
@@ -10364,7 +10364,7 @@ print_recreate_exception (enum exception
break;
case ex_catch_exception_unhandled:
- fprintf_filtered (fp, "catch unhandled");
+ fprintf_filtered (fp, "catch exception unhandled");
break;
case ex_catch_assert:
prev parent reply other threads:[~2010-04-19 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 0:36 Pedro Alves
2010-04-18 3:12 ` Eli Zaretskii
2010-04-19 16:16 ` Joel Brobecker
2010-04-19 17:07 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004191807.01058.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox