From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [v3] PR8554: New command to save breakpoints to a file
Date: Mon, 19 Apr 2010 16:16:00 -0000 [thread overview]
Message-ID: <20100419161631.GS19194@adacore.com> (raw)
In-Reply-To: <201004180136.25409.pedro@codesourcery.com>
Hi Pedro,
> 2010-04-18 Pedro Alves <pedro@codesourcery.com>
>
> PR breakpoints/8554.
>
> Implement `save-breakpoints'.
>
> gdb/
> * breakpoint.c (save_cmdlist): New.
> (breakpoint_set_cmdlist, breakpoint_show_cmdlist): Moved up close
> to save_cmdlist.
> (print_recreate_catch_fork): New.
> (catch_fork_breakpoint_ops): Install it.
> (print_recreate_catch_vfork): New.
> (catch_vfork_breakpoint_ops): Install it.
> (print_recreate_catch_syscall): New.
> (catch_syscall_breakpoint_ops): Install it.
> (print_recreate_catch_exec): New.
> (catch_exec_breakpoint_ops): Install it.
> (print_recreate_exception_catchpoint): New.
> (gnu_v3_exception_catchpoint_ops): Install it.
> (save_breakpoints): New, based on tracepoint_save_command, but
> handle all breakpoint types.
> (save_breakpoints_command): New.
> (tracepoint_save_command): Rename to...
> (save_tracepoints_command): ... this, and reimplement using
> save_breakpoints.
> (save_command): New.
> (_initialize_breakpoints): Install the "save" command prefix.
> Install the "save breakpoints" command. Make "save-tracepoints" a
> deprecated alias for "save tracepoints".
> * breakpoint.h (struct breakpoint_ops): New field `print_recreate'.
> * ada-lang.c (print_recreate_exception): New.
> (print_recreate_catch_exception): New.
> (catch_exception_breakpoint_ops): Install it.
> (print_recreate_catch_exception_unhandled): New.
> (catch_exception_unhandled_breakpoint_ops): Install it.
> (print_recreate_catch_assert): New.
> (catch_assert_breakpoint_ops): Install it.
>
> * NEWS: Mention the new `save breakpoints' command. Mention the
> new `save tracepoints' alias and that `save-tracepoints' is now
> deprecated.
>
> doc/
> * gdb.texinfo (Save Breakpoints): New node.
> (save-tracepoints): Rename to ...
> (save tracepoints): ... this. Mention that `save-tracepoints' is
> a deprecated alias to `save tracepoints'.
>
> gdb/testsuite/
> * gdb.trace/save-trace.exp: Adjust.
I think this is awesome. I hope this gets checked in soon, as I'm sure
many users will be glad to use it.
> + case ex_catch_exception_unhandled:
> + fprintf_filtered (fp, "catch unhandled");
> + break;
Just one nit: The right command is actually "catch exception unhandled".
--
Joel
next prev parent reply other threads:[~2010-04-19 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 0:36 Pedro Alves
2010-04-18 3:12 ` Eli Zaretskii
2010-04-19 16:16 ` Joel Brobecker [this message]
2010-04-19 17:07 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419161631.GS19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox