From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13311 invoked by alias); 19 Apr 2010 16:16:41 -0000 Received: (qmail 13293 invoked by uid 22791); 19 Apr 2010 16:16:39 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 16:16:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 165C42BAB94; Mon, 19 Apr 2010 12:16:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kSt6e1gBs+hj; Mon, 19 Apr 2010 12:16:33 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6097E2BABE3; Mon, 19 Apr 2010 12:16:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 07436F5895; Mon, 19 Apr 2010 09:16:31 -0700 (PDT) Date: Mon, 19 Apr 2010 16:16:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [v3] PR8554: New command to save breakpoints to a file Message-ID: <20100419161631.GS19194@adacore.com> References: <201004180136.25409.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004180136.25409.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00561.txt.bz2 Hi Pedro, > 2010-04-18 Pedro Alves > > PR breakpoints/8554. > > Implement `save-breakpoints'. > > gdb/ > * breakpoint.c (save_cmdlist): New. > (breakpoint_set_cmdlist, breakpoint_show_cmdlist): Moved up close > to save_cmdlist. > (print_recreate_catch_fork): New. > (catch_fork_breakpoint_ops): Install it. > (print_recreate_catch_vfork): New. > (catch_vfork_breakpoint_ops): Install it. > (print_recreate_catch_syscall): New. > (catch_syscall_breakpoint_ops): Install it. > (print_recreate_catch_exec): New. > (catch_exec_breakpoint_ops): Install it. > (print_recreate_exception_catchpoint): New. > (gnu_v3_exception_catchpoint_ops): Install it. > (save_breakpoints): New, based on tracepoint_save_command, but > handle all breakpoint types. > (save_breakpoints_command): New. > (tracepoint_save_command): Rename to... > (save_tracepoints_command): ... this, and reimplement using > save_breakpoints. > (save_command): New. > (_initialize_breakpoints): Install the "save" command prefix. > Install the "save breakpoints" command. Make "save-tracepoints" a > deprecated alias for "save tracepoints". > * breakpoint.h (struct breakpoint_ops): New field `print_recreate'. > * ada-lang.c (print_recreate_exception): New. > (print_recreate_catch_exception): New. > (catch_exception_breakpoint_ops): Install it. > (print_recreate_catch_exception_unhandled): New. > (catch_exception_unhandled_breakpoint_ops): Install it. > (print_recreate_catch_assert): New. > (catch_assert_breakpoint_ops): Install it. > > * NEWS: Mention the new `save breakpoints' command. Mention the > new `save tracepoints' alias and that `save-tracepoints' is now > deprecated. > > doc/ > * gdb.texinfo (Save Breakpoints): New node. > (save-tracepoints): Rename to ... > (save tracepoints): ... this. Mention that `save-tracepoints' is > a deprecated alias to `save tracepoints'. > > gdb/testsuite/ > * gdb.trace/save-trace.exp: Adjust. I think this is awesome. I hope this gets checked in soon, as I'm sure many users will be glad to use it. > + case ex_catch_exception_unhandled: > + fprintf_filtered (fp, "catch unhandled"); > + break; Just one nit: The right command is actually "catch exception unhandled". -- Joel