From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19662 invoked by alias); 19 Apr 2010 17:07:11 -0000 Received: (qmail 19653 invoked by uid 22791); 19 Apr 2010 17:07:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 17:07:04 +0000 Received: (qmail 29877 invoked from network); 19 Apr 2010 17:07:03 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Apr 2010 17:07:03 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [v3] PR8554: New command to save breakpoints to a file Date: Mon, 19 Apr 2010 17:07:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201004180136.25409.pedro@codesourcery.com> <20100419161631.GS19194@adacore.com> In-Reply-To: <20100419161631.GS19194@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004191807.01058.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00563.txt.bz2 On Monday 19 April 2010 17:16:31, Joel Brobecker wrote: > I think this is awesome. I hope this gets checked in soon, as I'm sure > many users will be glad to use it. Sorry, I had committed it yesterday evening/night, after Eli's docs approval, and got distracted by other things (including sleeping) and didn't get back here to say it explicitly. You'd have seen it had you been subscribed to gdb-cvs, though. ;-) > > > + case ex_catch_exception_unhandled: > > + fprintf_filtered (fp, "catch unhandled"); > > + break; > > Just one nit: The right command is actually "catch exception unhandled". Ah, thanks, missed that. I went ahead and applied the fix below. -- Pedro Alves 2010-04-19 Pedro Alves * ada-lang.c (print_recreate_exception) : It's "catch exception unhandled", not "catch unhandled". --- gdb/ada-lang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/ada-lang.c =================================================================== --- src.orig/gdb/ada-lang.c 2010-04-19 17:58:47.000000000 +0100 +++ src/gdb/ada-lang.c 2010-04-19 17:59:06.000000000 +0100 @@ -10364,7 +10364,7 @@ print_recreate_exception (enum exception break; case ex_catch_exception_unhandled: - fprintf_filtered (fp, "catch unhandled"); + fprintf_filtered (fp, "catch exception unhandled"); break; case ex_catch_assert: