[PATCH] gdb: tests: skip call-ar-st when noinferiorio

[PATCH] gdb: tests: skip call-ar-st when noinferiorio

[Mike Frysinger]

From: Jie Zhang <jie@codesourcery.com>

If the target cannot do input/output, skip the call-ar-st test.  For
example, testing via rsh/gdbserver cannot support this since the stdio
is not accessible via the host gdb.

Signed-off-by: Jie Zhang <jie@codesourcery.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-18  Jie Zhang  <jie@codesourcery.com>

	* gdb.base/call-ar-st.exp: Return if target has noinferiorio set.

 gdb/testsuite/gdb.base/call-ar-st.exp |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/gdb/testsuite/gdb.base/call-ar-st.exp b/gdb/testsuite/gdb.base/call-ar-st.exp
index 40ed86c..81cc419 100644
--- a/gdb/testsuite/gdb.base/call-ar-st.exp
+++ b/gdb/testsuite/gdb.base/call-ar-st.exp
@@ -46,6 +46,11 @@ if [get_compiler_info ${binfile}] {
     return -1;
 }
 
+if [target_info exists gdb,noinferiorio] {
+    untested "skipping call-ar-st.exp because of noinferiorio."
+    return -1
+}
+
 # Some targets can't call functions, so don't even bother with this
 # test.
 if [target_info exists gdb,cannot_call_functions] {
-- 
1.7.0.2

Re: [PATCH] gdb: tests: skip call-ar-st when noinferiorio

[Pedro Alves]

On Thursday 18 March 2010 07:17:00, Mike Frysinger wrote:
> From: Jie Zhang <jie@codesourcery.com>
> 
> If the target cannot do input/output, skip the call-ar-st test.  For
> example, testing via rsh/gdbserver cannot support this since the stdio
> is not accessible via the host gdb.

There's a bunch of gdb_skip_stdio_test checks in the test.
Why is that not working?

> 
> Signed-off-by: Jie Zhang <jie@codesourcery.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> 2010-03-18  Jie Zhang  <jie@codesourcery.com>
> 
> 	* gdb.base/call-ar-st.exp: Return if target has noinferiorio set.
> 
>  gdb/testsuite/gdb.base/call-ar-st.exp |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/call-ar-st.exp b/gdb/testsuite/gdb.base/call-ar-st.exp
> index 40ed86c..81cc419 100644
> --- a/gdb/testsuite/gdb.base/call-ar-st.exp
> +++ b/gdb/testsuite/gdb.base/call-ar-st.exp
> @@ -46,6 +46,11 @@ if [get_compiler_info ${binfile}] {
>      return -1;
>  }
>  
> +if [target_info exists gdb,noinferiorio] {
> +    untested "skipping call-ar-st.exp because of noinferiorio."
> +    return -1
> +}
> +
>  # Some targets can't call functions, so don't even bother with this
>  # test.
>  if [target_info exists gdb,cannot_call_functions] {
> 


-- 
Pedro Alves

Re: [PATCH] gdb: tests: skip call-ar-st when noinferiorio

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 617 bytes --]

On Thursday 18 March 2010 08:39:36 Pedro Alves wrote:
> On Thursday 18 March 2010 07:17:00, Mike Frysinger wrote:
> > From: Jie Zhang <jie@codesourcery.com>
> > 
> > If the target cannot do input/output, skip the call-ar-st test.  For
> > example, testing via rsh/gdbserver cannot support this since the stdio
> > is not accessible via the host gdb.
> 
> There's a bunch of gdb_skip_stdio_test checks in the test.
> Why is that not working?

it is working.  i compared the wrong set of test results and thought this was 
still necessary.  sorry for the noise ... time to go `rm -rf` some logs ;).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]