Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Mike Frysinger <vapier@gentoo.org>,  Jie Zhang <jie@codesourcery.com>
Subject: Re: [PATCH] gdb: tests: skip call-ar-st when noinferiorio
Date: Thu, 18 Mar 2010 12:39:00 -0000	[thread overview]
Message-ID: <201003181239.36970.pedro@codesourcery.com> (raw)
In-Reply-To: <1268896620-5005-1-git-send-email-vapier@gentoo.org>

On Thursday 18 March 2010 07:17:00, Mike Frysinger wrote:
> From: Jie Zhang <jie@codesourcery.com>
> 
> If the target cannot do input/output, skip the call-ar-st test.  For
> example, testing via rsh/gdbserver cannot support this since the stdio
> is not accessible via the host gdb.

There's a bunch of gdb_skip_stdio_test checks in the test.
Why is that not working?

> 
> Signed-off-by: Jie Zhang <jie@codesourcery.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> 2010-03-18  Jie Zhang  <jie@codesourcery.com>
> 
> 	* gdb.base/call-ar-st.exp: Return if target has noinferiorio set.
> 
>  gdb/testsuite/gdb.base/call-ar-st.exp |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/call-ar-st.exp b/gdb/testsuite/gdb.base/call-ar-st.exp
> index 40ed86c..81cc419 100644
> --- a/gdb/testsuite/gdb.base/call-ar-st.exp
> +++ b/gdb/testsuite/gdb.base/call-ar-st.exp
> @@ -46,6 +46,11 @@ if [get_compiler_info ${binfile}] {
>      return -1;
>  }
>  
> +if [target_info exists gdb,noinferiorio] {
> +    untested "skipping call-ar-st.exp because of noinferiorio."
> +    return -1
> +}
> +
>  # Some targets can't call functions, so don't even bother with this
>  # test.
>  if [target_info exists gdb,cannot_call_functions] {
> 


-- 
Pedro Alves


  reply	other threads:[~2010-03-18 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  7:17 Mike Frysinger
2010-03-18 12:39 ` Pedro Alves [this message]
2010-03-19 21:06   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003181239.36970.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jie@codesourcery.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox