[patch] Fix false warning: section .dynbss not found in ...

[patch] Fix false warning: section .dynbss not found in ...

[Jan Kratochvil]

Hi,

this is a follow-up on:
	http://sourceware.org/ml/gdb-patches/2010-02/msg00345.html
	http://sourceware.org/ml/gdb-patches/2010-02/msg00345.html

found two new sections by prelink:
	Reading symbols from /usr/bin/gdb...Reading symbols from /usr/lib/debug/usr/bin/gdb.debug...
	warning: section .dynbss not found in /usr/lib/debug/usr/bin/gdb.debug

Checked the prelink source (again) and I see no more of them there now.

No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.


Thanks,
Jan


2010-03-14  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* symfile.c (addr_info_make_relative): Ignore also missing ".dynbss"
	and ".sdynbss".  Simplify the comment.

--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -577,15 +577,16 @@ addr_info_make_relative (struct section_addr_info *addrs, bfd *abfd)
 	     unexpected and we want to issue a warning.
 
 	     However, the ELF prelinker does create a couple of sections
-	     (".gnu.liblist" and ".gnu.conflict") which are marked in the main
-	     executable as loadable (they are loaded in memory from the
-	     DYNAMIC segment) and yet are not present in separate debug info
-	     files.  This is fine, and should not cause a warning.  Shared
-	     libraries contain just the section ".gnu.liblist" but it is not
-	     marked as loadable there.  */
+	     which are marked in the main executable as loadable (they are
+	     loaded in memory from the DYNAMIC segment) and yet are not present
+	     in separate debug info files.  This is fine, and should not cause
+	     a warning.  Shared libraries contain just the section
+	     ".gnu.liblist" but it is not marked as loadable there.  */
 
 	  if (!(strcmp (sect_name, ".gnu.liblist") == 0
-		|| strcmp (sect_name, ".gnu.conflict") == 0))
+		|| strcmp (sect_name, ".gnu.conflict") == 0
+		|| strcmp (sect_name, ".dynbss") == 0
+		|| strcmp (sect_name, ".sdynbss") == 0))
 	    warning (_("section %s not found in %s"), sect_name,
 		     bfd_get_filename (abfd));
 

Re: [patch] Fix false warning: section .dynbss not found in ...

[Joel Brobecker]

> found two new sections by prelink:
> 	Reading symbols from /usr/bin/gdb...Reading symbols from /usr/lib/debug/usr/bin/gdb.debug...
> 	warning: section .dynbss not found in /usr/lib/debug/usr/bin/gdb.debug

:-) I was afraid that we'd find some of other sections that
needed to be excluded... :-/

> 2010-03-14  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* symfile.c (addr_info_make_relative): Ignore also missing ".dynbss"
> 	and ".sdynbss".  Simplify the comment.

OK, at least for now, but just a nit:

>  	     However, the ELF prelinker does create a couple of sections
> -	     (".gnu.liblist" and ".gnu.conflict") which are marked in the main
> -	     executable as loadable (they are loaded in memory from the
> -	     DYNAMIC segment) and yet are not present in separate debug info
> -	     files.  This is fine, and should not cause a warning.  Shared
> -	     libraries contain just the section ".gnu.liblist" but it is not
> -	     marked as loadable there.  */
> +	     which are marked in the main executable as loadable (they are
> +	     loaded in memory from the DYNAMIC segment) and yet are not present
> +	     in separate debug info files.  This is fine, and should not cause
> +	     a warning.  Shared libraries contain just the section
> +	     ".gnu.liblist" but it is not marked as loadable there.  */

The comment should say "a few sections" as opposed to "a couple" (a
couple is two, or three at most), and it should say that there is no
other way to identify these section except by name.

Pre-approved with that comment update.

-- 
Joel

Re: [patch] Fix false warning: section .dynbss not found in ...

[Jan Kratochvil]

On Mon, 15 Mar 2010 01:45:02 +0100, Joel Brobecker wrote:
> The comment should say "a few sections" as opposed to "a couple" (a
> couple is two, or three at most),

http://en.wiktionary.org/wiki/couple#Usage_notes
* In the U.S., "a couple of things" or people may be used to mean two of them,
  but it is also often used to mean any small number.
  	The farm is a couple of miles off the main highway [=a few miles away].

But I understand I can't argue about U.S. English. :-)


> and it should say that there is no
> other way to identify these section except by name.
> 
> Pre-approved with that comment update.

I hope it is +/- OK, checked-in.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-03/msg00138.html

--- src/gdb/ChangeLog	2010/03/15 03:48:46	1.11479
+++ src/gdb/ChangeLog	2010/03/15 09:31:30	1.11480
@@ -1,3 +1,8 @@
+2010-03-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* symfile.c (addr_info_make_relative): Ignore also missing ".dynbss"
+	and ".sdynbss".  Update the comment.
+
 2010-03-15  Jie Zhang  <jie@codesourcery.com>
 
 	* MAINTAINERS: Update my email address.
--- src/gdb/symfile.c	2010/03/10 18:20:07	1.277
+++ src/gdb/symfile.c	2010/03/15 09:31:34	1.278
@@ -576,16 +576,19 @@
 	  /* This section does not exist in ABFD, which is normally
 	     unexpected and we want to issue a warning.
 
-	     However, the ELF prelinker does create a couple of sections
-	     (".gnu.liblist" and ".gnu.conflict") which are marked in the main
-	     executable as loadable (they are loaded in memory from the
-	     DYNAMIC segment) and yet are not present in separate debug info
-	     files.  This is fine, and should not cause a warning.  Shared
-	     libraries contain just the section ".gnu.liblist" but it is not
-	     marked as loadable there.  */
+	     However, the ELF prelinker does create a few sections which are
+	     marked in the main executable as loadable (they are loaded in
+	     memory from the DYNAMIC segment) and yet are not present in
+	     separate debug info files.  This is fine, and should not cause
+	     a warning.  Shared libraries contain just the section
+	     ".gnu.liblist" but it is not marked as loadable there.  There is
+	     no other way to identify them than by their name as the sections
+	     created by prelink have no special flags.  */
 
 	  if (!(strcmp (sect_name, ".gnu.liblist") == 0
-		|| strcmp (sect_name, ".gnu.conflict") == 0))
+		|| strcmp (sect_name, ".gnu.conflict") == 0
+		|| strcmp (sect_name, ".dynbss") == 0
+		|| strcmp (sect_name, ".sdynbss") == 0))
 	    warning (_("section %s not found in %s"), sect_name,
 		     bfd_get_filename (abfd));
 

Re: [patch] Fix false warning: section .dynbss not found in ...

[Joel Brobecker]

> I hope it is +/- OK, checked-in.

This is perfect.

-- 
Joel